Grpc stub generation refactor #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoferrer
force-pushed
the
grpc-stub-generation-refactor
branch
from
ff556a1
to
c7b5245
Compare
marcoferrer
added a commit
that referenced
this pull request
Mar 14, 2019
* refactor grpc stub exts generator * update stub ext generation to use new coroutines api * add request parameter default value to stub generation * reduce member visibility in stub generators * coroutines api bug fixes and refinements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor code generation for grpc stub extensions. Update stub exts with new coroutines api. Add new default value for request message parameter in
grpc-coroutinesas well as stub exts. (Message.getDefaultInstance())