Fix issue with Gradle daemons hanging indefinitely on shutdown (elast…

…ic#44867)
mark-vieira · Jul 25, 2019 · 8e65c1a · 8e65c1a
1 parent 939f2e1
commit 8e65c1a
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 25 deletions.
diff --git a/...Src/src/main/java/org/elasticsearch/gradle/testclusters/TestClusterCleanupOnShutdown.java b/...Src/src/main/java/org/elasticsearch/gradle/testclusters/TestClusterCleanupOnShutdown.java
@@ -19,16 +19,12 @@ public class TestClusterCleanupOnShutdown implements Runnable {
 
     private Set<ElasticsearchCluster> clustersToWatch = new HashSet<>();
 
-    public void watch(Collection<ElasticsearchCluster> cluster) {
-        synchronized (clustersToWatch) {
-            clustersToWatch.addAll(clustersToWatch);
-        }
+    public synchronized void watch(Collection<ElasticsearchCluster> clusters) {
+        clustersToWatch.addAll(clusters);
     }
 
-    public void unWatch(Collection<ElasticsearchCluster> cluster) {
-        synchronized (clustersToWatch) {
-            clustersToWatch.removeAll(clustersToWatch);
-        }
+    public synchronized void unWatch(Collection<ElasticsearchCluster> clusters) {
+        clustersToWatch.removeAll(clusters);
     }
 
     @Override
@@ -38,21 +34,23 @@ public void run() {
                 Thread.sleep(Long.MAX_VALUE);
             }
         } catch (InterruptedException interrupted) {
-            synchronized (clustersToWatch) {
-                if (clustersToWatch.isEmpty()) {
-                    return;
-                }
-                logger.info("Cleanup thread was interrupted, shutting down all clusters");
-                Iterator<ElasticsearchCluster> iterator = clustersToWatch.iterator();
-                while (iterator.hasNext()) {
-                    ElasticsearchCluster cluster = iterator.next();
-                    iterator.remove();
-                    try {
-                        cluster.stop(false);
-                    } catch (Exception e) {
-                        logger.warn("Could not shut down {}", cluster, e);
-                    }
-                }
+            shutdownClusters();
+        }
+    }
+
+    public synchronized void shutdownClusters() {
+        if (clustersToWatch.isEmpty()) {
+            return;
+        }
+        logger.info("Cleanup thread was interrupted, shutting down all clusters");
+        Iterator<ElasticsearchCluster> iterator = clustersToWatch.iterator();
+        while (iterator.hasNext()) {
+            ElasticsearchCluster cluster = iterator.next();
+            iterator.remove();
+            try {
+                cluster.stop(false);
+            } catch (Exception e) {
+                logger.warn("Could not shut down {}", cluster, e);
             }
         }
     }

diff --git a/...Src/src/main/java/org/elasticsearch/gradle/testclusters/TestClustersCleanupExtension.java b/...Src/src/main/java/org/elasticsearch/gradle/testclusters/TestClustersCleanupExtension.java
@@ -33,7 +33,6 @@ public TestClustersCleanupExtension() {
         executorService.submit(cleanupThread);
     }
 
-
     public static void createExtension(Project project) {
         if (project.getRootProject().getExtensions().findByType(TestClustersCleanupExtension.class) != null) {
             return;
@@ -43,7 +42,7 @@ public static void createExtension(Project project) {
             "__testclusters_rate_limit",
             TestClustersCleanupExtension.class
         );
-        Thread shutdownHook = new Thread(ext.cleanupThread::run);
+        Thread shutdownHook = new Thread(ext.cleanupThread::shutdownClusters);
         Runtime.getRuntime().addShutdownHook(shutdownHook);
         project.getGradle().buildFinished(buildResult -> {
             ext.executorService.shutdownNow();