-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make No Empty Line Required Before GFM Tables #2298
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/markedjs/markedjs/3jZ6Pe17jPQAYApsgYCY8szu17ZJ |
7841ae6
to
f53aad3
Compare
f53aad3
to
ed875bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
## [4.0.5](v4.0.4...v4.0.5) (2021-11-25) ### Bug Fixes * table after paragraph without blank line ([#2298](#2298)) ([5714212](5714212))
🎉 This PR is included in version 4.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [marked](https://marked.js.org) ([source](https://github.com/markedjs/marked)) | dependencies | patch | [`4.0.4` -> `4.0.5`](https://renovatebot.com/diffs/npm/marked/4.0.4/4.0.5) | --- ### Release Notes <details> <summary>markedjs/marked</summary> ### [`v4.0.5`](https://github.com/markedjs/marked/releases/v4.0.5) [Compare Source](markedjs/marked@v4.0.4...v4.0.5) ##### Bug Fixes - table after paragraph without blank line ([#​2298](markedjs/marked#2298)) ([5714212](markedjs/marked@5714212)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Reviewed-on: https://kolaente.dev/vikunja/frontend/pulls/1085 Co-authored-by: renovate <renovatebot@kolaente.de> Co-committed-by: renovate <renovatebot@kolaente.de>
Uses
table
pattern to interruptparagraph
. So an empty line won't be required for GFM tables.Test cases added for this change.
Marked version: 4.0.4
Markdown flavor: GitHub Flavored Markdown
Description
Contributor
Committer
In most cases, this should be a different person than the contributor.