Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateTimesProperty should accept DateTimeInterface, not only DateTime #86

Closed
sc0rp10 opened this issue Mar 11, 2017 · 3 comments
Closed

DateTimesProperty should accept DateTimeInterface, not only DateTime #86

sc0rp10 opened this issue Mar 11, 2017 · 3 comments
Labels
enhancement
Milestone
Version 0.12.0

Comments

@sc0rp10
Copy link

sc0rp10 commented Mar 11, 2017

Now constructor fails on DateTimeImmutable
@navarr
Copy link
Contributor

navarr commented Mar 12, 2017

Current minimum requirement is PHP 5.3

Usage of \DateTimeInterface will bump the minimum requirement to 5.5.0

@markuspoerschke
Copy link
Owner

I think since PHP 5.3 is no longer supported we should drop that support as soon as there are some more and bigger changes coming in. But for now I don’t see a reason to drop PHP 5.3 support only because of \DateTimeInterface usage.

markuspoerschke added a commit that referenced this issue Apr 9, 2017
@markuspoerschke
Support \DateTimeInterface #86
862cbce
@markuspoerschke
Copy link
Owner

The master branch requires PHP 7.0 now. Therefore I replaced all \DateTime code hintings with \DateTimeInterface.

@sc0rp10 thanks for your valuable input.
@navarr thanks for your support with this task! :)

@markuspoerschke markuspoerschke added this to the Version 0.12.0 milestone Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Version 0.12.0
Development

No branches or pull requests
3 participants
@navarr @sc0rp10 @markuspoerschke