Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation on PHP #382

Merged
merged 3 commits into from
Apr 26, 2022

Conversation

xelan
Copy link
Contributor

@xelan xelan commented Feb 20, 2022

Q A
Branch? 2.x
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #345
License MIT

This PR fixes the deprecation message occuring on an OOTB Symfony 5.4 on PHP 7.4:

User Deprecated: Method "IteratorAggregate::getIterator()" might add "\Traversable" as a native return type declaration in the future. Do the same in implementation "Eluceo\iCal\Presentation\Component" now to avoid errors or add an explicit @return annotation to suppress this message.

The other issues outlined in #369 should already be solved, as the #[ReturnTypeWillChange] annotations are already present in those classes.

Thank you very much for the awesome library and best regards from Austria
Andreas

@markuspoerschke
Copy link
Owner

Hallo Andreas (@xelan), vielen Dank!

I adjusted the PR a little bit:

  1. I added a note to the changelog
  2. I converted the PHPDocBlock return type hint to a native return type of the method

@markuspoerschke markuspoerschke merged commit b8535a1 into markuspoerschke:2.x Apr 26, 2022
@xelan
Copy link
Contributor Author

xelan commented Apr 26, 2022

Thank you very much for merging 👍 Bitte, gerne 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation messages in Symfony 5.4
3 participants