Windows: Use %LOCALAPPDATA%/zigup as the default install directory. #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that the previous behaviour of using the zigup executable's own directory would result in both a `zig` directory, and a `zig.exe` file in the user's PATH. The directory would prevent the executable from being found under MSYS (e.g. trying to use zigup from within the bash install that comes with git).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous behaviour was to use the zigup executable's own directory.
The previous behaviour would result in both a
zigdirectory, and azig.exefile in the user's PATH. The directory would prevent the linked zig executable created by zigup from being found in PATH when running under MSYS (e.g. trying to use zigup from within the bash install that comes with git for windows). Using %LOCALAPPDATA% avoids this issue and better matches the behaviour on other platforms.Tested on Windows and Linux (under WSL) with LOCALAPPDATA/HOME:
Observed expected error output/success.