[Demo] Configure local Supabase instance to support invitation and password reset out of the box #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssword reset out of the box
djhi
reviewed
Oct 24, 2024
| <body> | ||
| <h2>You have been invited</h2> | ||
| <p>You have been invited to create a user on {{ .SiteURL }}. Follow this link to accept the invite:</p> | ||
| <p><a href="{{ .ConfirmationURL }}/auth-callback">Accept the invite</a></p> |
There was a problem hiding this comment.
I wonder if the doc is actually correct on this. Looking at https://supabase.com/docs/guides/auth/auth-email-templates#terminology, it seems the ConfirmationURL already contains the redirect_to parameter.
There was a problem hiding this comment.
After investigation, it appears this is the wrong solution. We shouldn't need to change the email template for the /auth-callback. Instead, we should modify the authProvider so that it specify the /auth-callback route as the redirectTo parameter of the supabase method calls that need it.
However, this change might break existing applications that followed the current documentation, so this is a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The documentation mentions how to customize the supabase emails to include the
/auth-callbackpath in the links it contains. However the demo itself does not apply this configuration, and instead still requires the user to manually copy the link and replace the end of the URL, which is confusing (and no longer necessary).Solution
Update the supabase local instance config as explained in the README to make it use the
/auth-callback, so that it works without requiring a manual replacement.