Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix authProvider.getPermissions() should not throw error when not logged in #79

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Fix authProvider.getPermissions() should not throw error when not logged in #79

merged 4 commits into from
Oct 29, 2024

Commits on Oct 28, 2024

  1. Fix authProvider.getPermissions() should not throw error when not l… 

    …ogged in

## Problem

The current setup disallows unauthenticated custom routes: the user is redirected to login.

## Solution

If no user is logged in, `getPermissions` should return `undefined` instead of redirecting to login.
    @fzaninotto
    fzaninotto committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    c28f5a7 View commit details
    Browse the repository at this point in the history

  2. Make authProvider.getPermissions optional

    @fzaninotto
    fzaninotto committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    1b4179e View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2024

  1. Revert "Make authProvider.getPermissions optional" 

    This reverts commit 1b4179e.
    @fzaninotto
    fzaninotto committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    2947e85 View commit details
    Browse the repository at this point in the history

  2. authProvider.getPermissions should leave early if there is no permiss… 

    …ions policy
    @fzaninotto
    fzaninotto committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    420b79e View commit details
    Browse the repository at this point in the history