Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm64 fix #173

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Arm64 fix #173

merged 2 commits into from
Nov 15, 2022

Conversation

pandu-k
Copy link
Collaborator

@pandu-k pandu-k commented Nov 15, 2022

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix

  • What is the current behavior? (You can also link to an open issue here)
    arm64 Docker build doesn't work

  • What is the new behavior (if this is a feature change)?
    arm64 Docker build works

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

Other information:

Tested across architectures:

  • Testing it on ubuntu amd64 environment
    • tox (api-tests) PASSED
    • unit tests PASSED
  • Testing it on ubuntu amd64 environment (api-tests)
    • tox -e py3-arm64_local_os (api-tests) PASSED
  • Test on cuda
    • pytest tests (api-tests, DIND config) PASSED
    • manually tested add_docs and search with device=cuda

@pandu-k pandu-k changed the title changed torch versions and simplified Dockerfile Arm64 fix Nov 15, 2022
@pandu-k pandu-k merged commit ad49c1c into mainline Nov 15, 2022
@pandu-k pandu-k deleted the arm64_fix_clean branch November 15, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants