Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enrichment] Multilingual clip #267

Merged
merged 28 commits into from
Jan 12, 2023
Merged

[Enrichment] Multilingual clip #267

merged 28 commits into from
Jan 12, 2023

Conversation

wanliAlex
Copy link
Collaborator

@wanliAlex wanliAlex commented Jan 10, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    features

  • What is the current behavior? (You can also link to an open issue here)
    we only support english as clip input

  • What is the new behavior (if this is a feature change)?
    we support multilingual inputs

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    not

  • Have unit tests been run against this PR? (Has there also been any additional testing?)
    yes

  • Related Python client changes (link commit/PR here)
    not

  • Related documentation changes (link commit/PR here)
    not yet

  • Other information:
    This pr is related to the issue

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

@wanliAlex wanliAlex temporarily deployed to marqo-test-suite January 10, 2023 09:48 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite January 10, 2023 09:48 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite January 10, 2023 09:48 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite January 10, 2023 09:48 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite January 10, 2023 10:47 — with GitHub Actions Inactive
Copy link
Collaborator

@pandu-k pandu-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just make sure it passes all test pipelines

@wanliAlex wanliAlex temporarily deployed to marqo-test-suite January 11, 2023 02:55 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite January 11, 2023 02:55 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite January 11, 2023 02:55 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite January 11, 2023 02:55 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite January 11, 2023 02:55 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite January 11, 2023 06:43 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite January 12, 2023 00:50 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite January 12, 2023 00:50 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite January 12, 2023 00:50 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite January 12, 2023 00:50 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite January 12, 2023 00:50 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite January 12, 2023 00:50 — with GitHub Actions Inactive
@wanliAlex wanliAlex merged commit 6cc9de4 into mainline Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants