-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enrichment] Multilingual clip #267
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanliAlex
temporarily deployed
to
marqo-test-suite
January 10, 2023 09:48
— with
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
January 10, 2023 09:48
— with
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
January 10, 2023 09:48
— with
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
January 10, 2023 09:48
— with
GitHub Actions
Inactive
wanliAlex
had a problem deploying
to
marqo-test-suite
January 10, 2023 09:48
— with
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
January 10, 2023 09:51
— with
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
January 10, 2023 10:39
— with
GitHub Actions
Failure
wanliAlex
temporarily deployed
to
marqo-test-suite
January 10, 2023 10:47
— with
GitHub Actions
Inactive
wanliAlex
had a problem deploying
to
marqo-test-suite
January 10, 2023 10:56
— with
GitHub Actions
Failure
wanliAlex
had a problem deploying
to
marqo-test-suite
January 11, 2023 02:00
— with
GitHub Actions
Error
pandu-k
approved these changes
Jan 11, 2023
pandu-k
reviewed
Jan 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just make sure it passes all test pipelines
wanliAlex
temporarily deployed
to
marqo-test-suite
January 11, 2023 02:55
— with
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
January 11, 2023 02:55
— with
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
January 11, 2023 02:55
— with
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
January 11, 2023 02:55
— with
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
January 11, 2023 02:55
— with
GitHub Actions
Inactive
wanliAlex
had a problem deploying
to
marqo-test-suite
January 11, 2023 03:47
— with
GitHub Actions
Error
wanliAlex
had a problem deploying
to
marqo-test-suite
January 11, 2023 04:57
— with
GitHub Actions
Error
wanliAlex
had a problem deploying
to
marqo-test-suite
January 11, 2023 05:49
— with
GitHub Actions
Error
wanliAlex
temporarily deployed
to
marqo-test-suite
January 11, 2023 06:43
— with
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
January 12, 2023 00:50
— with
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
January 12, 2023 00:50
— with
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
January 12, 2023 00:50
— with
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
January 12, 2023 00:50
— with
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
January 12, 2023 00:50
— with
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
January 12, 2023 00:50
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
features
What is the current behavior? (You can also link to an open issue here)
we only support english as clip input
What is the new behavior (if this is a feature change)?
we support multilingual inputs
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
not
Have unit tests been run against this PR? (Has there also been any additional testing?)
yes
Related Python client changes (link commit/PR here)
not
Related documentation changes (link commit/PR here)
not yet
Other information:
This pr is related to the issue
Please check if the PR fulfills these requirements