Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opensearch's team fix for reducing search latency #278

Merged
merged 1 commit into from
Jan 22, 2023
Merged

Conversation

danyilq
Copy link
Contributor

@danyilq danyilq commented Jan 20, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Opensearch's 2.4 release led to serious speed latency issues because of new segmentation strategy of the Lucene 9.4 Decrease Marqo-os latencies via index settings[ENHANCEMENT] #265
    This pr adds new index setting that would prevent further issues and in total leads to:

    • Significant search speed optimisation on high scale
    • reduce of index total size
    • little speed up of indexing
  • What is the current behavior? (You can also link to an open issue here)
    Decrease Marqo-os latencies via index settings[ENHANCEMENT] #265
    "took" field from executing single vector search on a 10mil vector index:
    image

  • What is the new behavior (if this is a feature change)?
    After fix "took" field from executing single vector search on a 10mil vector index:
    image

  • Have unit tests been run against this PR? (Has there also been any additional testing?)
    All the tensor_search passed while some model testing failed, probably this is related to M1 architecture.
    As well tested index creation and verified that settings are applied and indeed affect index performance

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

@danyilq danyilq requested a review from pandu-k January 20, 2023 11:49
@pandu-k pandu-k temporarily deployed to marqo-test-suite January 22, 2023 22:28 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite January 22, 2023 22:28 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite January 22, 2023 22:28 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite January 22, 2023 22:28 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite January 22, 2023 23:14 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite January 22, 2023 23:14 — with GitHub Actions Inactive
@pandu-k pandu-k merged commit 3ddda3c into mainline Jan 22, 2023
@pandu-k pandu-k deleted the latency-fix branch January 22, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants