Mappings for add_docs #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/marqo/tensor_search/validation.py
pandu-k
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
pandu-k
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
pandu-k
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
# Conflicts: # src/marqo/tensor_search/validation.py
pandu-k
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
wanliAlex
approved these changes
Feb 27, 2023
wanliAlex
added a commit
that referenced
this pull request
Feb 28, 2023
* draft PR * add test * delete comments and prints * new design * adding test * add assertion * change comments * add more args * add more test * remove print * catch mainline * catch mainline * catch mainline * catch mainline * catch mainline * catch mainline * adding test * adding test * change _infer_opensearch_data_type * support dictionary * fix text * add test * revise parameters * add to image repo * revise again. * revised * add batch downloading. * revise test * add new test * remove space * revised. * revised. * revised. * revised. * update index info * update index info * update validation * update test for new api * updated * updated * add validate mappings * add todo * revised * revised * revised * revised * revised * revised * revised * add test * add test * add test * Mappings for add_docs (#355) * Update CONTRIBUTING.md * Update CONTRIBUTING.md * Adding mappings validation * mappings validation within add_documents * added mappings to endpoint and orchestrator: untested * add test * add more tests * add more tests * add more tests * finalise * add open_search test * update all the error messages. * update all the error messages. --------- Co-authored-by: pandu-k <107458762+pandu-k@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
No mappings validation
What is the new behavior (if this is a feature change)?
Mappings validation
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Have unit tests been run against this PR? (Has there also been any additional testing?)
not yet
Related Python client changes (link commit/PR here)
To do
Related documentation changes (link commit/PR here)
https://docs.marqo.ai/0.0.15/API-Reference/mappings/
Other information:
Please check if the PR fulfills these requirements