-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stateless model auth #460
Merged
Merged
Stateless model auth #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rerunning tests after corrections: https://github.com/marqo-ai/marqo/actions/runs/4890507706 |
# Conflicts: # tests/tensor_search/test_lexical_search.py
pandu-k
had a problem deploying
to
marqo-test-suite
May 10, 2023 11:07
— with
GitHub Actions
Failure
pandu-k
had a problem deploying
to
marqo-test-suite
May 10, 2023 11:52
— with
GitHub Actions
Failure
wanliAlex
temporarily deployed
to
marqo-test-suite
May 10, 2023 23:36
— with
GitHub Actions
Inactive
wanliAlex
temporarily deployed
to
marqo-test-suite
May 10, 2023 23:39
— with
GitHub Actions
Inactive
wanliAlex
approved these changes
May 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Impressive work!
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature: allows for OpenCLIP and CLIP models to be downloaded from remote model stores (s3, HF) with authorisation.
What is the current behavior? (You can also link to an open issue here)
There is no way to download models from these datastores if authorisation is required
What is the new behavior (if this is a feature change)?
Allows for OpenCLIP and CLIP models to be downloaded from remote model stores (s3, HF) with authorisation.
Also removes unreliable test of deprecated endpoint:
test_put_documents_orchestrator()
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Have unit tests been run against this PR? (Has there also been any additional testing?)
Yes
Related Python client changes (link commit/PR here)
added model_auth to search, bulk_search, and add_docs py-marqo#87
Related documentation changes (link commit/PR here)
To do
Other information:
Please check if the PR fulfills these requirements