Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stateless model auth #460

Merged
merged 60 commits into from
May 11, 2023
Merged

Stateless model auth #460

merged 60 commits into from
May 11, 2023

Conversation

pandu-k
Copy link
Collaborator

@pandu-k pandu-k commented May 4, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature: allows for OpenCLIP and CLIP models to be downloaded from remote model stores (s3, HF) with authorisation.

  • What is the current behavior? (You can also link to an open issue here)
    There is no way to download models from these datastores if authorisation is required

  • What is the new behavior (if this is a feature change)?
    Allows for OpenCLIP and CLIP models to be downloaded from remote model stores (s3, HF) with authorisation.

Also removes unreliable test of deprecated endpoint: test_put_documents_orchestrator()

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Have unit tests been run against this PR? (Has there also been any additional testing?)
    Yes

  • Related Python client changes (link commit/PR here)
    added model_auth to search, bulk_search, and add_docs py-marqo#87

  • Related documentation changes (link commit/PR here)
    To do

  • Other information:

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

@pandu-k
Copy link
Collaborator Author

pandu-k commented May 5, 2023

@pandu-k
Copy link
Collaborator Author

pandu-k commented May 5, 2023

Rerunning tests after corrections: https://github.com/marqo-ai/marqo/actions/runs/4890507706

@pandu-k pandu-k temporarily deployed to marqo-test-suite May 10, 2023 02:18 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite May 10, 2023 02:18 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite May 10, 2023 04:44 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite May 10, 2023 11:08 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite May 10, 2023 11:51 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite May 10, 2023 11:52 — with GitHub Actions Inactive
@pandu-k pandu-k temporarily deployed to marqo-test-suite May 10, 2023 13:25 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite May 10, 2023 23:36 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite May 10, 2023 23:39 — with GitHub Actions Inactive
Copy link
Collaborator

@wanliAlex wanliAlex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive work!

@pandu-k pandu-k merged commit 02837cf into mainline May 11, 2023
@pandu-k pandu-k deleted the pandu/model-auth-stateless branch May 11, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants