-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New E5 Models in Registry #568
Conversation
Add extra tests for e5 models and multilingual sbert models
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Li! Do we need a test ensuring that we can create a new index with one of the new model types, as expected, and then add a doc and search?
@pandu-k is there anything pending on this? |
Hi Owen, thanks for this!
|
I tested all of these models locally with a dev build of Marqo before I raised this PR. I haven't benchmarked them though our simple wiki demo is using e5-base-v2 https://demo.marqo.ai/?q=what+is+isaac+newton+known+for&index=simplewiki |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature - new E5 Models
What is the current behavior? (You can also link to an open issue here)
E5 V2 and multilingual E5 models are not in the registry
What is the new behavior (if this is a feature change)?
E5 V2 and multilingual E5 models are now in the registry
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Have unit tests been run against this PR? (Has there also been any additional testing?)
All unit tests pass. Indexes created with the new models work as expected.
Related documentation changes (link commit/PR here)
https://github.com/marqo-ai/marqodocs/pull/111
Please check if the PR fulfills these requirements