Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New E5 Models in Registry #568

Merged
merged 4 commits into from
Aug 24, 2023
Merged

New E5 Models in Registry #568

merged 4 commits into from
Aug 24, 2023

Conversation

OwenPendrighElliott
Copy link
Contributor

@OwenPendrighElliott OwenPendrighElliott commented Aug 9, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature - new E5 Models

  • What is the current behavior? (You can also link to an open issue here)
    E5 V2 and multilingual E5 models are not in the registry

  • What is the new behavior (if this is a feature change)?
    E5 V2 and multilingual E5 models are now in the registry

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Have unit tests been run against this PR? (Has there also been any additional testing?)
    All unit tests pass. Indexes created with the new models work as expected.

  • Related documentation changes (link commit/PR here)
    https://github.com/marqo-ai/marqodocs/pull/111

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

@OwenPendrighElliott OwenPendrighElliott marked this pull request as ready for review August 9, 2023 06:38
Add extra tests for e5 models and multilingual sbert models
Copy link
Collaborator

@pandu-k pandu-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Li! Do we need a test ensuring that we can create a new index with one of the new model types, as expected, and then add a doc and search?

@OwenPendrighElliott
Copy link
Contributor Author

@pandu-k is there anything pending on this?

@OwenPendrighElliott OwenPendrighElliott temporarily deployed to marqo-test-suite August 24, 2023 03:24 — with GitHub Actions Inactive
@pandu-k
Copy link
Collaborator

pandu-k commented Aug 24, 2023

Hi Owen, thanks for this!

  • Have some of these models been manually end-to-end (as part of a Marqo index) tested for performance (recall + latency). Eyeballing is fine for now at this stage.
  • Do we need a test ensuring that we can create a new index with one of the new model types, as expected, and then add a doc and search? @wanliAlex do you have any examples of these types of tests?
  • It would be good for @wanliAlex to also have a review

@OwenPendrighElliott
Copy link
Contributor Author

Hi Owen, thanks for this!

  • Have some of these models been manually end-to-end (as part of a Marqo index) tested for performance (recall + latency). Eyeballing is fine for now at this stage.

I tested all of these models locally with a dev build of Marqo before I raised this PR. I haven't benchmarked them though our simple wiki demo is using e5-base-v2 https://demo.marqo.ai/?q=what+is+isaac+newton+known+for&index=simplewiki

@wanliAlex wanliAlex temporarily deployed to marqo-test-suite August 24, 2023 05:50 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite August 24, 2023 05:50 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite August 24, 2023 05:50 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite August 24, 2023 05:50 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite August 24, 2023 05:50 — with GitHub Actions Inactive
@wanliAlex wanliAlex temporarily deployed to marqo-test-suite August 24, 2023 05:51 — with GitHub Actions Inactive
@OwenPendrighElliott OwenPendrighElliott merged commit 37b5eb3 into mainline Aug 24, 2023
22 checks passed
@OwenPendrighElliott OwenPendrighElliott deleted the owen/new-e5-models branch August 24, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants