Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memory limit note to README.md #602

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

vicilliar
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    docs update

  • What is the current behavior? (You can also link to an open issue here)
    lacking explanation of out of memory error for docker

  • What is the new behavior (if this is a feature change)?
    note explains why docker container usually dies inexplicably

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Have unit tests been run against this PR? (Has there also been any additional testing?)

  • Related Python client changes (link commit/PR here)

  • Related documentation changes (link commit/PR here)

  • Other information:

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@OwenPendrighElliott OwenPendrighElliott temporarily deployed to marqo-test-suite September 13, 2023 05:01 — with GitHub Actions Inactive
@OwenPendrighElliott OwenPendrighElliott temporarily deployed to marqo-test-suite September 13, 2023 05:01 — with GitHub Actions Inactive
@OwenPendrighElliott OwenPendrighElliott temporarily deployed to marqo-test-suite September 13, 2023 05:01 — with GitHub Actions Inactive
@OwenPendrighElliott OwenPendrighElliott temporarily deployed to marqo-test-suite September 13, 2023 05:01 — with GitHub Actions Inactive
@OwenPendrighElliott OwenPendrighElliott temporarily deployed to marqo-test-suite September 13, 2023 05:01 — with GitHub Actions Inactive
@OwenPendrighElliott OwenPendrighElliott temporarily deployed to marqo-test-suite September 13, 2023 05:01 — with GitHub Actions Inactive
@vicilliar vicilliar merged commit 22f3fa6 into mainline Sep 13, 2023
20 checks passed
@pandu-k pandu-k deleted the joshua/readme-note-memory-limit branch September 14, 2023 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants