Fix telemetry cleanup bug #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farshidz
force-pushed
the
farshid/telemetry-fix
branch
from
b69c13f
to
cfd0dd2
Compare
farshidz
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
pandu-k
previously approved these changes
Apr 10, 2024
pandu-k
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
pandu-k
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
pandu-k
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
pandu-k
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
pandu-k
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
pandu-k
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
pandu-k
approved these changes
Apr 10, 2024
farshidz
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
pandu-k
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
pandu-k
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
pandu-k
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
pandu-k
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
pandu-k
temporarily deployed
to
marqo-test-suite
GitHub Actions
Inactive
pandu-k
had a problem deploying
to
marqo-test-suite
GitHub Actions
Failure
farshidz
added a commit
that referenced
this pull request
Apr 15, 2024
* Fix bug where telemetry does not clean up objects when telemetry=false * Add a memory profiler endpoint /memory, disabled by default and enabled through an environment variable
wanliAlex
pushed a commit
that referenced
this pull request
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Fix bug where telemetry does not clean up objects when telemetry=false
This PR also adds a memory profiler endpoint
/memorydisabled by default and enable through an environment variableWhat is the current behavior? (You can also link to an open issue here)
When telemetry=false, Telemetry leaks objects by adding a class variable and not cleaning up when the request is complete
What is the new behavior (if this is a feature change)?
Clean up the dict when done
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Have unit tests been run against this PR? (Has there also been any additional testing?)
Yes
Related Python client changes (link commit/PR here)
No
Related documentation changes (link commit/PR here)
No
Other information:
Please check if the PR fulfills these requirements