Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dependency injection in shut down #850

Merged
merged 2 commits into from
May 28, 2024
Merged

Conversation

wanliAlex
Copy link
Collaborator

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    bug fix

  • What is the current behavior? (You can also link to an open issue here)
    there is a possibility that the dependency injection is failed in API shutdown

  • What is the new behavior (if this is a feature change)?
    we remove the dependency injection and get the needed object manually

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Have unit tests been run against this PR? (Has there also been any additional testing?)
    no

  • Related Python client changes (link commit/PR here)
    no

  • Related documentation changes (link commit/PR here)
    no

  • Other information:
    no

  • Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

farshidz
farshidz previously approved these changes May 28, 2024
@farshidz farshidz merged commit fd56800 into mainline May 28, 2024
2 checks passed
@farshidz farshidz deleted the li/patch-shutdown branch May 28, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants