Gcc 7 4 0 patch #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A diagnostic ID was compared to floating point 0. to test if it had been set. This patch replaces this with an integer inequality test. This resolves GitHub Issue mom-ocean#1016. Thanks to Stephen Griffies for reporting.
ALE: Float ID inequality replaced with integer
Codecov Report
@@ Coverage Diff @@
## tc4_fix #1 +/- ##
===========================================
- Coverage 44.69% 42.09% -2.61%
===========================================
Files 212 212
Lines 62242 62244 +2
===========================================
- Hits 27822 26203 -1619
- Misses 34420 36041 +1621
Continue to review full report at Codecov.
|
|
I think that my PR had the problematic test filtered out: Do you want to remove the |
|
OK. That would explain why test passed. I'll try again |
marshallward
pushed a commit
that referenced
this pull request
Nov 14, 2019
T scaling and OpenMP fixes
marshallward
pushed a commit
that referenced
this pull request
Mar 23, 2021
Bugfix: sign error on fprec for nuopc and mct caps
marshallward
pushed a commit
that referenced
this pull request
Mar 29, 2022
update with NOAA-EMC fork
marshallward
added a commit
that referenced
this pull request
May 3, 2022
Note that most of these commits are from previously squashed pull requests, and this PR is restoring them. - 6360dbb Merge branch 'main' into main_to_dev - bac8031 Merge pull request mom-ocean#1566 from jiandewang/EMC-FMS-mixed-mode-20220411 - e532d86 Merge pull request mom-ocean#88 from marshallward/missing_attrib_with_class_bugfix - d380f1d An alternate fix to class(*) issues with FMS 2022-01 - 8ecf333 Merge pull request mom-ocean#87 from jiandewang/feature/update-to-main-20220317 - ba37f94 Merge remote-tracking branch 'FSU/main' into feature/update-to-main-20220317 this is corresponding to MOM6 main 20220317 commit (hash # 399a7db) - 44313d9 Merge pull request mom-ocean#85 from jiandewang/feature/update-to-main-20220217 - 966707f Merge remote-tracking branch 'GFDL/main' into feature/update-to-main-20220217 this is corresponding to MOM6 main branch 20220217 commit (hash # 6f6d4d6), which originally based on GFDL-candidate-20220129 - 32c0e1e Merge pull request mom-ocean#81 from jiandewang/feature/update-to-main-20211220 - 9642b1d delete external/OCEAN_stochastic_phyiscs directory as Phil re-coded in external/stochastic_physics directory - e7c9ada solve minor conflict in mom_cap.F90 mom_ocean_model_nuopc.F90 and MOM_energetic_PBL.F90, add two new files: src/parameterizations/stochastic/MOM_stochastics.F90 and config_src/external/stochastic_physics/stochastic_physics.F90 - 90d5961 Merge pull request mom-ocean#78 from jiandewang/feature/update-to-GFDL-20211019 - fd02017 Merge remote-tracking branch 'GFDL/main' into feature/update-to-GFDL-20211019 - 36f17eb Merge pull request mom-ocean#72 from pjpegion/ocn_stoch_july2021 - a9a957e return a more accurate error message in MOM_stochasics - 56bb41e Merge branch 'ocn_stoch_july2021' of https://github.com/pjpegion/MOM6 into ocn_stoch_july2021 - ca2ae1c update to dev/emc - 14ca4a1 Merge pull request mom-ocean#76 from jiandewang/feature/update-to-GFDL-20210914 - 29016c2 Merge remote-tracking branch 'GFDL/main' into feature/update-to-GFDL-20210914 merge GFDL main 20210914 commit (hash # c09e199) - a8577df Merge branch 'NOAA-EMC:dev/emc' into ocn_stoch_july2021 - f8a8e4c update to gfdl 20210806 (mom-ocean#74) - 16e6af0 update to dev/emc - 237a510 add comments - 1b4273d revert logic wrt increments - 5b2040e add logic to remove incrments from restart if outside IAU window - c5f2b72 add write_stoch_restart_ocn to MOM_stochastics - bdf2dc7 doxygen cleanup - 8bc4acc move stochastics to external directory - a3fa3a1 Merge remote-tracking branch 'upstream/dev/emc' into ocn_stoch_july2021 - e4bc007 stochastic physics re-write - 202cbd4 update to dev/emc - 61717ee Merge remote-tracking branch 'origin/dev/emc' into ocn_stoch - 565e0bb remove debug statements - a4c0411 Merge remote-tracking branch 'upstream/dev/emc' into ocn_stoch - 689a73f remove PE_here from mom_ocean_model_nuopc.F90 - 8afe969 clean up of mom_ocean_model_nuopc.F90 - 25ed4fc revert MOM_domains.F90 - b8d9888 place stochastic array in fluxes container and make SPPT specific arrays allocatable - d984a7e remove stochastics container - eb88219 clean up of code for MOM6 coding standards - 6e3ea1b correct coupled_driver/ocean_model_MOM.F90 and other cleanup - 0b99c1f make stochastics optional - 85023f8 Merge remote-tracking branch 'upstream/dev/emc' into ocn_stoch - 80f9f44 clean up MOM_domains - 5443f8e remove blank link in MOM_diagnostics - 1727d9a re-write of stochastic code to remove CPP directives - 600ebf9 Merge remote-tracking branch 'upstream/dev/emc' into ocn_stoch - 6bb9d0b fix non stochastic ePBL calculation - 1d7ffa3 clean up code - 040e1f1 Merge pull request #13 from NOAA-EMC/dev/emc - 2cba995 Merge branch 'dev/emc' into ocn_stoch - 1dc0f4f Merge remote-tracking branch 'upstream/dev/emc' into dev/emc - 4bd9b9e clean up debug statements - 25ed5ef additions for stochy restarts - a2a374b add stochy_restart writing to mom_cap - 0c15f4c Update MOM_diabatic_driver.F90 - 167a62e Merge pull request #12 from pjpegion/dev/emc - bd477a9 Update MOM_diabatic_driver.F90 - 7212400 Update MOM_diabatic_driver.F90 - 7de295c cleanup of code and enhancement of ePBL perts - cd06356 Merge pull request #11 from NOAA-EMC/dev/emc - 9896d61 Merge pull request #9 from pjpegion/dev/emc_merge - 0a62737 Merge branch 'ocn_stoch' into dev/emc_merge - 3cad1ba Merge pull request #8 from NOAA-EMC/dev/emc - c2aa2a8 updates from dev/emc - 182ef34 additions for stochastic physics and ePBL perts - 671c714 Merge pull request #1 from NOAA-EMC/dev/emc
marshallward
added a commit
that referenced
this pull request
Jun 20, 2022
* Autoconf: Fix makedep path The current path of makedep in the autoconf build assumes a directory tree as in .testing. This patch uses the generalized @SrcDir@ to support more general autoconf builds. Other minor changes: * The `depend` rule was split into an explicit Makefile.dep rule and a phony rule to support `make depend` * SRC_DIRS shell assignment is replaced with an Autoconf macro. * A "self-generate" rule was added to `Makefile.in`, so that changes to `Makefile.in` do not trigger a full `./configure` run and regeneration of `.config.status`. This could possibly be extended to support `make depend` but let's first see how this one goes. * Autoconf: makedep uses autoconf var conventions This patch changes the makedep script to use autoconf environment variable conventions rather than mkmf ones: * FCFLAGS in place of FFLAGS * DEFS in place of CPPDEFS * LDFLAGS and LIBS rather than just LDFLAGS (NOTE: This differs from Makefile's LDLFLAGS/LDLIBS) This also allowed us to remove the custom build rule in the FMS build. Note that we now use an autoconf-friendly rule, rather than the default Makefile rule (which was arguably for fixed-format Fortran anyway). The description of autoconf->mkmf translation from the Makefile templates has also been removed, since they're no longer relevant. Some other minor changes in this build: * The `make depend` rule was added to the FMS Makefile template. * @SrcDir@ is directly passed to FMS makedep, rather than identically re-defining it in a variable. * Testing: Resolve makedep paths This patch resolves some issues relating to finding the path to makedep in both .testing and more generalized autoconf builds. An explicit autoconf test for makedep has been added, with a default path which includes the `ac` directory relative to `deps`. The .testing directory, which does not lie within `ac`, instead modifies the PATH to allow autoconf to find makedep. The absolute path is determined and substituted into the appropriate Makefile.in template. Some redundant operations in .testing/Makefile have been removed, but I suspect there are even more. Much of the structure required to support mkmf and list_paths is probably no longer needed.
marshallward
added a commit
that referenced
this pull request
Jul 5, 2022
This reverts commit 4bcc849.
marshallward
added a commit
that referenced
this pull request
Jul 5, 2022
This reverts commit 4bcc849.
marshallward
added a commit
that referenced
this pull request
Feb 22, 2023
Commit #1 --------- Removes calls to mpp_open, and replaces then with FATAL MOM_error calls when present. This also introduces the idea where only domain-decomposed files are used with infra IO. I've floated this idea a few times and people seem supportive, but it may not necessarily be embraced by everyone. Also moves Vertical_coordinate.nc from infra to native netCDF. This is primarily a trial balloon to see how the regression suite holds up. Commit #2 --------- mpp_open removal This formally removes the mpp_open functions, along with the FMS_writes control flag. Hopefully there is nothing much interesting here. Also removed open_file_unit since it's no longer used, and renamed open_file_type to open_file since the interface serves no purpose.
marshallward
added a commit
that referenced
this pull request
Feb 23, 2023
Commit #1 --------- Removes calls to mpp_open, and replaces then with FATAL MOM_error calls when present. This also introduces the idea where only domain-decomposed files are used with infra IO. I've floated this idea a few times and people seem supportive, but it may not necessarily be embraced by everyone. Also moves Vertical_coordinate.nc from infra to native netCDF. This is primarily a trial balloon to see how the regression suite holds up. Commit #2 --------- mpp_open removal This formally removes the mpp_open functions, along with the FMS_writes control flag. Hopefully there is nothing much interesting here. Also removed open_file_unit since it's no longer used, and renamed open_file_type to open_file since the interface serves no purpose.
marshallward
added a commit
that referenced
this pull request
Mar 3, 2023
Commit #1 --------- Removes calls to mpp_open, and replaces then with FATAL MOM_error calls when present. This also introduces the idea where only domain-decomposed files are used with infra IO. I've floated this idea a few times and people seem supportive, but it may not necessarily be embraced by everyone. Also moves Vertical_coordinate.nc from infra to native netCDF. This is primarily a trial balloon to see how the regression suite holds up. Commit #2 --------- mpp_open removal This formally removes the mpp_open functions, along with the FMS_writes control flag. Hopefully there is nothing much interesting here. Also removed open_file_unit since it's no longer used, and renamed open_file_type to open_file since the interface serves no purpose.
marshallward
pushed a commit
that referenced
this pull request
Sep 30, 2024
Symmetric instability streamfunction init
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.