Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review as modal instead of a custom view #3

Open
DaveyUS opened this issue Apr 29, 2021 · 2 comments
Open

Review as modal instead of a custom view #3

DaveyUS opened this issue Apr 29, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@DaveyUS
Copy link

DaveyUS commented Apr 29, 2021

I'm requesting this without the knowledge of how difficult this would be to achieve... but I think having the review act as it's own pop-out panel would solve a couple of problems. Take a look at my Settings panel as I have it configured via CSS:

popout

It dims and blurs the rest of obsidian, allowing for a more focused, zen-like setting-changing experience. Something like this would be really great for reviewing flashcards. Also, I find that with the current implementation as a page, if I close or reload the app it will relaunch with a blank page that I have to close out of. I'd imagine this change would probably take care as well.

Again I don't know how difficult this would be to pull off, but I think it would be worth it!

@martin-jw martin-jw changed the title Review as a popout instead of a page Review as modal instead of a custom view Apr 30, 2021
@martin-jw martin-jw added the enhancement New feature or request label Apr 30, 2021
@martin-jw
Copy link
Owner

This is definitely something that is possible, but I think there are advantages to both approaches.

A modal for the review view is more focused, while a custom view allows you to quickly fix typos or errors without closing the review view. I will look into this and see which works best, or if both have their trade-offs I might implement it as a setting.

As for the review view not keeping its state after closing or reloading the app, I split that into a separate issue, #4.

@DaveyUS
Copy link
Author

DaveyUS commented Apr 30, 2021

Good point. For me, typos will be very rare, so hitting the open file button to edit wouldn't be much of a chore when it does happen inside a modal. There will for sure be people who would prefer a page though, so having an option would be the best approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants