cli: hint about how to recover from failed export of branches #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user creates a branch with an empty name, it seems very likely to be an accident. Let's help them realize that by erroring out. I didn't add the same checks to `jj branch delete`, since that would make it hard to delete a branch with an empty name from existing repos.
I can't see any reason the user would want to specify revisions matching the empty string, so let's disallow it. I created a custom type for revision arguments instead of repeating `value_parser = NonEmptyStringValueParser::new()`.
Base automatically changed from
push-833f54401e084c10b9f6753d59a35a26
to
main
November 28, 2022 19:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md