Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tos to windows installer #1237

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Add tos to windows installer #1237

merged 3 commits into from
Oct 19, 2023

Conversation

thomas-senechal
Copy link
Member

@thomas-senechal thomas-senechal commented Oct 19, 2023

Delivery Quality Checklist

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.
  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label
  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?
  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

QA:

  1. Download Windows installer
  2. Start it
  3. Click next on the Welcome page
  4. Make sure you see the "license" page

@thomas-senechal thomas-senechal linked an issue Oct 19, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4e18860) 25.66% compared to head (2664522) 28.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1237      +/-   ##
==========================================
+ Coverage   25.66%   28.44%   +2.77%     
==========================================
  Files          25       21       -4     
  Lines        1535     1378     -157     
==========================================
- Hits          394      392       -2     
+ Misses       1128      973     -155     
  Partials       13       13              

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas-senechal thomas-senechal marked this pull request as ready for review October 19, 2023 08:52
Copy link
Contributor

@gregLibert gregLibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, it works.

@LucasF243
Copy link

it works

@gregLibert gregLibert merged commit e4f60ba into main Oct 19, 2023
17 checks passed
@gregLibert gregLibert deleted the add-tos-to-windows-installer branch October 19, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User must agree on T&C before install
3 participants