Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WoC console.log #1257

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Remove WoC console.log #1257

merged 1 commit into from
Nov 8, 2023

Conversation

pivilartisant
Copy link
Contributor

@pivilartisant pivilartisant commented Nov 8, 2023

Delivery Quality Checklist

  • Breaking Changes in API:
    Does this PR introduce breaking changes in the API?

    • If yes, have you considered making it backward compatible?
    • If backward compatibility is not considered, set the "breaking-change" label.
  • Changelog:

    • For bugfix PR, set the "bugfix" label
    • If this change should not appear in changelog, use "ignore-for-changelog" label
  • Version Update Handling:
    Have you ensured that the version update by user is handled correctly?

  • PR Dependency:
    Does this PR depend on another PR?

    • If yes, is it necessary for the dependency to be released prior to merging this one?
  • Documentation:

    • Are any necessary changes made to user-facing documentation?
    • Confirm that API documentation is updated with any relevant changes.
    • Check that README and other documentation files are accurate and current.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (33957a0) 25.27% compared to head (eb742e6) 20.67%.

❗ Current head eb742e6 differs from pull request most recent head a90012a. Consider uploading reports for the commit a90012a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1257      +/-   ##
==========================================
- Coverage   25.27%   20.67%   -4.60%     
==========================================
  Files          25       19       -6     
  Lines        1559     1248     -311     
==========================================
- Hits          394      258     -136     
+ Misses       1152      978     -174     
+ Partials       13       12       -1     

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas-senechal
Copy link
Member

Should we also remove those logs ?

console.log(website.name, response.status);

And this should be a console.error ?

console.log(`error fetching favicon for ${website.name}.massa`, error);

@Thykof
Copy link
Contributor

Thykof commented Nov 8, 2023

Should we also remove those logs ?

console.log(website.name, response.status);

And this should be a console.error ?

console.log(`error fetching favicon for ${website.name}.massa`, error);

The first one, yes.

The second on, no, and it should be console.error

@Thykof Thykof merged commit f334b5b into main Nov 8, 2023
15 checks passed
@Thykof Thykof deleted the remove-clog branch November 8, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants