-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable dashboard plugin update #1351
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pivilartisant
force-pushed
the
enable-plugin-dashboard-update
branch
from
April 22, 2024 15:53
a6d91ba
to
06db72a
Compare
Thykof
approved these changes
Apr 23, 2024
Thykof
previously requested changes
Apr 23, 2024
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1351 +/- ##
==========================================
- Coverage 22.09% 15.87% -6.23%
==========================================
Files 29 24 -5
Lines 1715 1531 -184
==========================================
- Hits 379 243 -136
+ Misses 1326 1279 -47
+ Partials 10 9 -1 ☔ View full report in Codecov by Sentry. |
Thykof
reviewed
Apr 24, 2024
Thykof
force-pushed
the
enable-plugin-dashboard-update
branch
from
April 24, 2024 12:41
d4124c2
to
f324722
Compare
Thykof
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Plugin Wallet is now a component hosted in station repo (not ui-kit)
Update Plugin logic is contained in a custom hook and called in two places: dashboard and plugin store
These changes enables the user to directly update MW plugin in the dashboard ui without having to navigate to the plugin store