-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add deploy Sc #1370
Open
pivilartisant
wants to merge
10
commits into
main
Choose a base branch
from
add-deploy-sc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add deploy Sc #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
int/api/cmd/deploySC.go
Outdated
Comment on lines
18
to
19
//go:embed sc | ||
var content embed.FS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can directly embed the SC like:
Suggested change
//go:embed sc | |
var content embed.FS | |
//go:embed sc/deployer.wasm | |
var deployerSC []byte |
Like that, you don't need to do the content.ReadFile
line 31
pivilartisant
commented
Nov 29, 2024
pkg/onchain/datastore.go
Outdated
Comment on lines
21
to
53
func argsKey(offset int) ([]byte, error) { | ||
// Create a buffer to serialize data | ||
var buf bytes.Buffer | ||
|
||
// Add U64 (64-bit unsigned integer) | ||
err := binary.Write(&buf, binary.LittleEndian, uint64(offset+1)) | ||
if err != nil { | ||
return nil, err | ||
} | ||
|
||
// Add Uint8Array equivalent (assuming a single byte array with a 0 value) | ||
buf.Write([]byte{0}) | ||
|
||
// Return the serialized data | ||
return buf.Bytes(), nil | ||
} | ||
|
||
func coinsKey(offset int) ([]byte, error) { | ||
// Create a buffer to serialize data | ||
var buf bytes.Buffer | ||
|
||
// Add U64 (64-bit unsigned integer) | ||
err := binary.Write(&buf, binary.LittleEndian, uint64(offset+1)) | ||
if err != nil { | ||
return nil, err | ||
} | ||
|
||
// Add Uint8Array equivalent (assuming a single byte array with a 0 value) | ||
buf.Write([]byte{1}) | ||
|
||
// Return the serialized data | ||
return buf.Bytes(), nil | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
func argsKey(offset int) ([]byte, error) { | |
// Create a buffer to serialize data | |
var buf bytes.Buffer | |
// Add U64 (64-bit unsigned integer) | |
err := binary.Write(&buf, binary.LittleEndian, uint64(offset+1)) | |
if err != nil { | |
return nil, err | |
} | |
// Add Uint8Array equivalent (assuming a single byte array with a 0 value) | |
buf.Write([]byte{0}) | |
// Return the serialized data | |
return buf.Bytes(), nil | |
} | |
func coinsKey(offset int) ([]byte, error) { | |
// Create a buffer to serialize data | |
var buf bytes.Buffer | |
// Add U64 (64-bit unsigned integer) | |
err := binary.Write(&buf, binary.LittleEndian, uint64(offset+1)) | |
if err != nil { | |
return nil, err | |
} | |
// Add Uint8Array equivalent (assuming a single byte array with a 0 value) | |
buf.Write([]byte{1}) | |
// Return the serialized data | |
return buf.Bytes(), nil | |
} | |
func argsKey(offset int) ([]byte, error) { | |
// Create a buffer to serialize data | |
var buf bytes.Buffer | |
// Add U64 (64-bit unsigned integer) | |
err := binary.Write(&buf, binary.LittleEndian, uint64(offset+1)) | |
if err != nil { | |
return nil, err | |
} | |
// Add Uint8Array equivalent (assuming a single byte array with a 0 value) | |
buf.Write([]byte{0}) | |
// Return the serialized data | |
return buf.Bytes(), nil | |
} | |
func coinsKey(offset int) ([]byte, error) { | |
// Create a buffer to serialize data | |
var buf bytes.Buffer | |
// Add U64 (64-bit unsigned integer) | |
err := binary.Write(&buf, binary.LittleEndian, uint64(offset+1)) | |
if err != nil { | |
return nil, err | |
} | |
// Add Uint8Array equivalent (assuming a single byte array with a 0 value) | |
buf.Write([]byte{1}) | |
// Return the serialized data | |
return buf.Bytes(), nil | |
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delivery Quality Checklist
Breaking Changes in API:
Does this PR introduce breaking changes in the API?
Changelog:
Version Update Handling:
Have you ensured that the version update by user is handled correctly?
PR Dependency:
Does this PR depend on another PR?
Documentation: