remove uploaded date and import metadata to front #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASAPSegfault
approved these changes
Nov 22, 2022
gregLibert
suggested changes
Nov 22, 2022
There was a problem hiding this comment.
🙅
I don't understand the business need but I challenge the technical choice:
- why using pointer instead of actual value to fill an array, as both array and underlying objects are created on purpose
- you are creating a function's logic that doesn't match its name and comment
Thykof
requested changes
Nov 22, 2022
Thykof
approved these changes
Nov 22, 2022
Thykof
deleted the
268-correct-the-website-uploaded-date-on-the-registry-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please check issue to see why we choosed to remove the date