Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: fix CI and factorize install #309

Merged
merged 2 commits into from
Nov 28, 2022
Merged

CI: fix CI and factorize install #309

merged 2 commits into from
Nov 28, 2022

Conversation

peterjah
Copy link
Contributor

No description provided.

@peterjah peterjah linked an issue Nov 28, 2022 that may be closed by this pull request
Ci fails #308
Closed
@peterjah peterjah changed the title CI: factorize linux install CI: fix CI and factorize install Nov 28, 2022
@peterjah peterjah force-pushed the 308-ci-fails branch 12 times, most recently from 9c847a9 to c077c83 Compare November 28, 2022 13:00
thomas-senechal
thomas-senechal approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@thomas-senechal thomas-senechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good improvements !

Thykof
Thykof reviewed Nov 28, 2022
View reviewed changes
Copy link
Contributor

@Thykof Thykof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! is it possible to factor build job to avoid duplicate code between build and release worflows

@peterjah
Copy link
Contributor Author

peterjah commented Nov 28, 2022 •
edited
Loading

Great! is it possible to factor build job to avoid duplicate code between build and release worflows

Of couse sir !! Lets do it

Thykof
Thykof approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@Thykof Thykof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@peterjah peterjah force-pushed the 308-ci-fails branch 4 times, most recently from c5f10dd to 5aa0e73 Compare November 28, 2022 15:14
@gregLibert gregLibert merged commit 0c2cf5f into main Nov 28, 2022
@gregLibert gregLibert deleted the 308-ci-fails branch November 28, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-senechal thomas-senechal thomas-senechal approved these changes

@Thykof Thykof Thykof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ci fails
4 participants
@peterjah @Thykof @thomas-senechal @gregLibert