Core/dp 20569 design principles #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clairesunstudio
changed the base branch from
develop
to
core/storybook-integration
|
Before: After: |
clairesunstudio
approved these changes
Nov 30, 2020
clairesunstudio
added a commit
that referenced
this pull request
Dec 21, 2020
* setup core storybook * circle update * add installation doc * add icons index to git * bring in icon set display * add rush react:build command * update * move button copy styles into assets * add typography and move header footer into folders * fix core stories and add button story * cleanup react typography and fix icon story button copy styles * use Canvas in core button story * fix header styles * header * add footer docs and fix styles * add colors * add gradients and styles * document color * typo * add chromatic * wip * wip intro * add heading doc * test story * add storybook source package * add story name * remove sb cra preset * fix story * only show docs * render html * add link docs * generate component css * add html snippets * wip * add examples * hide code for first example * add logo docs * fix color swatch title display * add notes * link css to all button stories * cleanup code * render all footer html * footer stories cleanup * render code snippets for all headers * render code snippets for headings * refactor link stories * format html and display state seal CDN url * combine multiple heading stories into one for full width formatting * add append css in existing stories * add js and css notes to header * add css notes in footer * add wip header * Core/storybook use env var for CDN path versioning (#1247) * add STORYBOOK_CDN_PATH env var to display version specific cdn path * update docs to use env var * version control css * fix logo links * match seal file name with modifier * fix regex * cleanup unused * add background addon and test setting background in mdx * Revert "add background addon and test setting background in mdx" This reverts commit 03ed658. * create state seal stories * adjust color seal outline thickness and export for png * remove bg * add color bg combinations * update descriptions * adjust colorSwatch component * add color swatches to logo doc * style color swatches * add colors * edit * add download links * remove unused * Docs work typography (#1277) * Imported mayflower theme to docs For some reason storybook requires it to be impoerted there as well to available in the docs pages. Also made somee tweaks to the Mayflower sstorybook theme. * Updates to styles, markup and content for typography. Plus a few minor content changes to 'about' * Update packages/core/stories/tokens/typography/Typography.stories.mdx Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Update packages/core/stories/tokens/typography/Typography.stories.mdx Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Update packages/core/stories/about/Usage.stories.mdx Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Updated vertical spacing -reverted fallbacks -reverted numbers -added class for language labels -added language labels to languages that didn't have them -indented language labels to differentiate from scripts -Corrected script names -added rtl class for labels -Moved sample to top * Apply suggestions from code review Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Core/dp 20569 design principles (#1281) * Updated content and layout * clean up and fix styles Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Core/cleanup (#1279) * cleanup unused * remove unused package * order stories * Core/auto update version env var (#1274) * break up env var * add script * export update core version func * fix export * test * update func * update func * remove passing in global var and fix the func (checkout this commit to test the scripts) * remove test comments * apply review suggestions * fix error * Update scripts/update-version.js Co-authored-by: Steven Murray <smurrayatwork@gmail.com> * Revert "Update scripts/update-version.js" This reverts commit bd720a8. * Revert "apply review suggestions" This reverts commit c55cec3. Co-authored-by: Steven Murray <smurrayatwork@gmail.com> * Core/template docs (#1285) * move narrow template theme styles * add build assets rush command * wip * add place holder * add reverse template and JS note * fix seal url in template * add doc * remove toolbar in story * fix links * add link to template doc from usage doc * add code template * Update packages/core/stories/styles/index.scss * Update packages/core/stories/styles/index.scss * Core/dp 20570 design tokens (#1286) * Updates to the colors story * Updates to logo page content and layout * Updates to pr per Minghua -reverted hierarchical to primary, alt, highlight sections -moved down semantic colors to below theme colors -fixed typo 'palette' * Removed logo display file * tweaks and fixes * tweaks and fixes * capitalization * match variable names * tweaks and fixes for logo docs * swapped incorrectly oredered size labels * add additional background color usage info Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Core/dp 20309 overview documentation (#1284) * Updated the structure of links and content and the layout of Introduction * Re-ordered brand pillars to top of principles * Update packages/core/stories/principles/Accessibility.stories.mdx Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Moved sandbox style to end * Added imports to resolve conflict * Reverted preview js * Create _place-holder.scss -to resolve conflict with core/storybook-integration * Reverted meta.json -moved this work to navigation pr * Fixed wrap of li * Implemented LinkTo * Updated the structure of links and content and the layout of Introduction * Re-ordered brand pillars to top of principles * Update packages/core/stories/principles/Accessibility.stories.mdx Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Moved sandbox style to end * Reverted preview js * Reverted meta.json -moved this work to navigation pr * Fixed wrap of li * Implemented LinkTo * DP-20568-storybook-navigation-update (#1290) * Added navigation update * Update meta.json * Re-organize links * Deleted some test files * Updated links Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * refactor introduction menu story links to use SectionLink component * update intro * fix and reorder * remove unused styles; Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Core/storybook minor fixes (#1292) * fix urls in examples * clean up and add version in theme title * add build core rush command * Core/storybook auto deploy (#1295) * fix urls in examples * clean up and add version in theme title * add build core rush command * add auto deploy scripts * trigger tasks * fix * add storybook cli * force update * fix storybook command * force update * remove rushx * recreate pnpm-lock.yaml * switch docker image * add path * add mayflower-react build step into core_build_storybook * fix deploy task * install aws * remove copies of node modules * use pnpx instead of npx * only sync for stable tags * reset release trigger time and add deploy core to tag job * test cleaning up old files * fix * remove copying assets static * fix * remove test code * fix * Core/overview quickstart (#1300) * specify mayflower theme for docs * reorganize get started doc * upate doc * Update packages/core/stories/about/Usage.stories.mdx * add cdn examples * Core/base elements content only (#1299) * Updatess to buttons and headings -Normalized heading line hieights just for display here -Gave buttons the names of their types -some code-block cleanup for readability -Fixed typos -Added missing color attribute * Updated content * Updated buttons with 2 column layout * Changed h4 to inline strong * Updates to all elements pages * Update packages/core/stories/elements/Button/Button.stories.mdx Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Removed grid markup -also removed grid override CSS -replaced hr class with style for the element agnosstic to bottom or top -replaced all hr tags with markdown (`---`) * Added withSource noe back to buttons first strory also made some minor typo fixes and added bullets * Update packages/core/stories/elements/Button/Button.stories.mdx Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Update packages/core/stories/elements/Button/Button.stories.mdx Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Update packages/core/stories/elements/Button/Button.stories.mdx Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Update packages/core/stories/elements/Link/Link.stories.mdx Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Update packages/core/stories/styles/index.scss Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Some minor tweaks from comments * Typo fixes * Update packages/core/stories/elements/Link/Link.stories.mdx * Update packages/core/stories/elements/Link/Link.stories.mdx Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Core/dp-20670-accessibility-docs-updates (#1303) * Edited down accessibility resources, added to Accesibility main * Added link to resources * Updated linkto * Updated resources to just out links * Edited down accessibility resources, added to Accesibility main * Added link to resources * Updated linkto * Updated resources to just out links * More updates to text -fixed broken links -added some new descriptions * Core/storybook linting (#1301) * fix urls in examples * clean up and add version in theme title * add build core rush command * add auto deploy scripts * trigger tasks * fix * add storybook cli * force update * fix storybook command * force update * remove rushx * recreate pnpm-lock.yaml * switch docker image * add path * add mayflower-react build step into core_build_storybook * fix deploy task * install aws * remove copies of node modules * use pnpx instead of npx * only sync for stable tags * reset release trigger time and add deploy core to tag job * copy react linting setup * auto lint fix * wip * wip and add missing dependency * wip * wip * lint fix and missing dependency * lint fix and missing dependency * add linting to circle * fix task order * fix build * fix circle * update requires * fix shrinkwrap error * attempt to force update cache * Updates react, assets package.json to their up to date version numbers. * Bumps circleci cache key. * Sets all packages to use the same version of sass, updates mayflower-assets version for mayflower-react dev dependencies. Co-authored-by: smurrayatwork <steven.murray@mediacurrent.com> * update to 10.4.0 * Core/new header docs (#1313) * add header * add header hamburger component * update story * fix lint * Updates typography stories -to comment out fonts not yet supported. * Revert "Updates typography stories" This reverts commit 3335358. * add changelogs Co-authored-by: Terrence Kevin Oleary <terrenceoleary@gmail.com> Co-authored-by: Steven Murray <smurrayatwork@gmail.com> Co-authored-by: smurrayatwork <steven.murray@mediacurrent.com>
clairesunstudio
added a commit
that referenced
this pull request
Dec 29, 2020
* setup core storybook * circle update * add installation doc * add icons index to git * bring in icon set display * add rush react:build command * update * move button copy styles into assets * add typography and move header footer into folders * fix core stories and add button story * cleanup react typography and fix icon story button copy styles * use Canvas in core button story * fix header styles * header * add footer docs and fix styles * add colors * add gradients and styles * document color * typo * add chromatic * wip * wip intro * add heading doc * test story * add storybook source package * add story name * remove sb cra preset * fix story * only show docs * render html * add link docs * generate component css * add html snippets * wip * add examples * hide code for first example * add logo docs * fix color swatch title display * add notes * link css to all button stories * cleanup code * render all footer html * footer stories cleanup * render code snippets for all headers * render code snippets for headings * refactor link stories * format html and display state seal CDN url * combine multiple heading stories into one for full width formatting * add append css in existing stories * add js and css notes to header * add css notes in footer * add wip header * Core/storybook use env var for CDN path versioning (#1247) * add STORYBOOK_CDN_PATH env var to display version specific cdn path * update docs to use env var * version control css * fix logo links * match seal file name with modifier * fix regex * cleanup unused * add background addon and test setting background in mdx * Revert "add background addon and test setting background in mdx" This reverts commit 03ed658. * create state seal stories * adjust color seal outline thickness and export for png * remove bg * add color bg combinations * update descriptions * adjust colorSwatch component * add color swatches to logo doc * style color swatches * add colors * edit * add download links * remove unused * Docs work typography (#1277) * Imported mayflower theme to docs For some reason storybook requires it to be impoerted there as well to available in the docs pages. Also made somee tweaks to the Mayflower sstorybook theme. * Updates to styles, markup and content for typography. Plus a few minor content changes to 'about' * Update packages/core/stories/tokens/typography/Typography.stories.mdx Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Update packages/core/stories/tokens/typography/Typography.stories.mdx Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Update packages/core/stories/about/Usage.stories.mdx Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Updated vertical spacing -reverted fallbacks -reverted numbers -added class for language labels -added language labels to languages that didn't have them -indented language labels to differentiate from scripts -Corrected script names -added rtl class for labels -Moved sample to top * Apply suggestions from code review Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Core/dp 20569 design principles (#1281) * Updated content and layout * clean up and fix styles Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Core/cleanup (#1279) * cleanup unused * remove unused package * order stories * Core/auto update version env var (#1274) * break up env var * add script * export update core version func * fix export * test * update func * update func * remove passing in global var and fix the func (checkout this commit to test the scripts) * remove test comments * apply review suggestions * fix error * Update scripts/update-version.js Co-authored-by: Steven Murray <smurrayatwork@gmail.com> * Revert "Update scripts/update-version.js" This reverts commit bd720a8. * Revert "apply review suggestions" This reverts commit c55cec3. Co-authored-by: Steven Murray <smurrayatwork@gmail.com> * Core/template docs (#1285) * move narrow template theme styles * add build assets rush command * wip * add place holder * add reverse template and JS note * fix seal url in template * add doc * remove toolbar in story * fix links * add link to template doc from usage doc * add code template * Update packages/core/stories/styles/index.scss * Update packages/core/stories/styles/index.scss * Core/dp 20570 design tokens (#1286) * Updates to the colors story * Updates to logo page content and layout * Updates to pr per Minghua -reverted hierarchical to primary, alt, highlight sections -moved down semantic colors to below theme colors -fixed typo 'palette' * Removed logo display file * tweaks and fixes * tweaks and fixes * capitalization * match variable names * tweaks and fixes for logo docs * swapped incorrectly oredered size labels * add additional background color usage info Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Core/dp 20309 overview documentation (#1284) * Updated the structure of links and content and the layout of Introduction * Re-ordered brand pillars to top of principles * Update packages/core/stories/principles/Accessibility.stories.mdx Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Moved sandbox style to end * Added imports to resolve conflict * Reverted preview js * Create _place-holder.scss -to resolve conflict with core/storybook-integration * Reverted meta.json -moved this work to navigation pr * Fixed wrap of li * Implemented LinkTo * Updated the structure of links and content and the layout of Introduction * Re-ordered brand pillars to top of principles * Update packages/core/stories/principles/Accessibility.stories.mdx Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Moved sandbox style to end * Reverted preview js * Reverted meta.json -moved this work to navigation pr * Fixed wrap of li * Implemented LinkTo * DP-20568-storybook-navigation-update (#1290) * Added navigation update * Update meta.json * Re-organize links * Deleted some test files * Updated links Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * refactor introduction menu story links to use SectionLink component * update intro * fix and reorder * remove unused styles; Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Core/storybook minor fixes (#1292) * fix urls in examples * clean up and add version in theme title * add build core rush command * Core/storybook auto deploy (#1295) * fix urls in examples * clean up and add version in theme title * add build core rush command * add auto deploy scripts * trigger tasks * fix * add storybook cli * force update * fix storybook command * force update * remove rushx * recreate pnpm-lock.yaml * switch docker image * add path * add mayflower-react build step into core_build_storybook * fix deploy task * install aws * remove copies of node modules * use pnpx instead of npx * only sync for stable tags * reset release trigger time and add deploy core to tag job * test cleaning up old files * fix * remove copying assets static * fix * remove test code * fix * Core/overview quickstart (#1300) * specify mayflower theme for docs * reorganize get started doc * upate doc * Update packages/core/stories/about/Usage.stories.mdx * add cdn examples * Core/base elements content only (#1299) * Updatess to buttons and headings -Normalized heading line hieights just for display here -Gave buttons the names of their types -some code-block cleanup for readability -Fixed typos -Added missing color attribute * Updated content * Updated buttons with 2 column layout * Changed h4 to inline strong * Updates to all elements pages * Update packages/core/stories/elements/Button/Button.stories.mdx Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Removed grid markup -also removed grid override CSS -replaced hr class with style for the element agnosstic to bottom or top -replaced all hr tags with markdown (`---`) * Added withSource noe back to buttons first strory also made some minor typo fixes and added bullets * Update packages/core/stories/elements/Button/Button.stories.mdx Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Update packages/core/stories/elements/Button/Button.stories.mdx Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Update packages/core/stories/elements/Button/Button.stories.mdx Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Update packages/core/stories/elements/Link/Link.stories.mdx Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Update packages/core/stories/styles/index.scss Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Some minor tweaks from comments * Typo fixes * Update packages/core/stories/elements/Link/Link.stories.mdx * Update packages/core/stories/elements/Link/Link.stories.mdx Co-authored-by: Minghua Sun <clairesunstudio@gmail.com> * Core/dp-20670-accessibility-docs-updates (#1303) * Edited down accessibility resources, added to Accesibility main * Added link to resources * Updated linkto * Updated resources to just out links * Edited down accessibility resources, added to Accesibility main * Added link to resources * Updated linkto * Updated resources to just out links * More updates to text -fixed broken links -added some new descriptions * Core/storybook linting (#1301) * fix urls in examples * clean up and add version in theme title * add build core rush command * add auto deploy scripts * trigger tasks * fix * add storybook cli * force update * fix storybook command * force update * remove rushx * recreate pnpm-lock.yaml * switch docker image * add path * add mayflower-react build step into core_build_storybook * fix deploy task * install aws * remove copies of node modules * use pnpx instead of npx * only sync for stable tags * reset release trigger time and add deploy core to tag job * copy react linting setup * auto lint fix * wip * wip and add missing dependency * wip * wip * lint fix and missing dependency * lint fix and missing dependency * add linting to circle * fix task order * fix build * fix circle * update requires * fix shrinkwrap error * attempt to force update cache * Updates react, assets package.json to their up to date version numbers. * Bumps circleci cache key. * Sets all packages to use the same version of sass, updates mayflower-assets version for mayflower-react dev dependencies. Co-authored-by: smurrayatwork <steven.murray@mediacurrent.com> * add react storybook UI banner * move build scss into scss * update banner * wip patternlab * update to 10.4.0 * wip * Core/new header docs (#1313) * add header * add header hamburger component * update story * fix lint * tweak theme * fix site build * style lint * format and adjust style * fix inline decorative link * fix patternlab styles for banner * update package.json to revert storybook versions * fix missing dependencies * Core/fix missing styles (#1325) * add markdown styles * fix markdown styles * upgrade core storybook to 6.1.10 * fix styles * full width table * adjust styles * title cases * fix styles * fix header styles * fix logo color swatches alignment * fix heading vertical spaces * regerenate all backstop images (#1326) * add changelog * add changelog * conflict Co-authored-by: Terrence Kevin Oleary <terrenceoleary@gmail.com> Co-authored-by: Steven Murray <smurrayatwork@gmail.com> Co-authored-by: smurrayatwork <steven.murray@mediacurrent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to content and layout on the brand pillars page
Related Issue / Ticket
Steps to Test
Screenshots