-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile menu #53
Merged
Merged
Mobile menu #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code is mostly unchanged from what has been used on several projects including Parsons, Rising Bank, MBC. It was improved slightly for menu open/close behavior and a resize watcher to close the menu on screens 960+
unscripted
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
This PR enhances the Core Navigation block's mobile experience. The styling is improved with left-aligned items that have spacing and bottom borders. The submenu's can be opened by clicking the arrow. The top menu item is added to the menu allowing it to be clickable to dropdown the menu and the first submenu item is the new link to the top menu item.
If the menu is "About us" and it has a submenu. Then the top item "About us" will only function to reveal to submenu rather than a link to the "About us" page. Then in the submenu, "About us" is the first link and takes you to that page.
This feature has been tested in several existing projects like: Parsons, Rising Bank, and MBC. In this projects it was refined and it is refined further here. Some issues were addressed like the submenu not opening on click the first couple of tries and the mobile menu was not hiding if you increased the browser width. This left it unstyled and covering the page until a refresh of the page by the user. There's a resize function that hides the menu when increasing the screen over 960 width.
Closes https://app.asana.com/0/1203895219649773/1206518703604992/f
Pre-submit checklist
As the author of this pull request, I verify that:
master
.Testing
How to test the changes in this pull request
Follow the steps below to test the changes in this PR.
Functional tests
As the functional tester for this pull request, I verify that:
Once testing is complete, notify the author of any failed tests and move the task to "Kick back" in Asana. If all tests pass, move the task to "Ready for Code Review" in Asana and tag a team member for code review.
Code review
As the code reviewer for this pull request, I verify that:
Once testing is complete, notify the author of any failed tests and move the task to "Kick back" in Asana or continue with the "merging" steps below.
Merging
As the individual merging this pull request, I verify that: