Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the cancel search/close button in search box #209

Closed
coliff opened this issue Dec 17, 2018 · 1 comment
Closed

Fix the cancel search/close button in search box #209

coliff opened this issue Dec 17, 2018 · 1 comment
Labels
bug

Comments

@coliff
Copy link
Contributor

coliff commented Dec 17, 2018 •
edited
Loading

The close/cancel button in search input box doesn't show or work like the GetGrav site has.
https://learn.getgrav.org/
@coliff coliff changed the title Add cancel search/close button to search box Fix the cancel search/close button in search box Dec 19, 2018
@coliff
Copy link
Contributor Author

coliff commented Dec 20, 2018

Update: I fixed it! The issue is that the close button is referencing a Font Awesome icon which isn't available fa-close, it should actually be fa-times. I'll open a PR.

@coliff coliff mentioned this issue Dec 20, 2018
Merged
@matalo33 matalo33 added the bug label Jan 27, 2019
gr1m0h pushed a commit to gr1m0h/hugo-theme-learn that referenced this issue Mar 7, 2021
@coliff
This fixes the close/cancel search icon not showing
f601e12 
This fixes issue: matcornic#209
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
@McShelby
mobile: fix navigation UX matcornic#209 matcornic#210
ea8b527
maxatome pushed a commit to maxatome/hugo-theme-learn that referenced this issue Jan 23, 2024
@McShelby
toc: animation improvements matcornic#209
17964b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coliff @matalo33