refactor: add some improvements #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* replace unused variable with `_` * `throw` stops running the code in a function, so don't need to use `else` then * `||`-operator is working wrong when falsy values go, so better replace them with `!=`-operator (as it's not strict and only `undefined` and `null` are usable there) * better put conditions out of `for` loop to not evaluating the condition over and over for no need * `+0.0` and `0.0` are exactly same values * `[].slice` is shorter than `Array.prototype.slice` * sometimes saving values to an arguments can take more time, it might be ambiguous * `Math.max` and `Math.min` work longer than your own implementation * `check` function can take `any` values now with `Number.isFinite` *
|
@mateogianolio please have a look at it The PR fixes Issue#113 about |
|
Hey @Beraliv! Looks great, I’m on my phone right now so I'll have a look at it and merge tomorrow. Thank you so much for your contribution! |
|
There are some problems with |
|
Seems like nyc requires node >= 6. I updated node version in travis to 6.9.0, let's see if it works. |
|
Yep, that was it! Great job 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_throwstops running the code in a function, so don't need to useelsethen||-operator is working wrong when falsy values go, so better replace them with!=-operator (as it's not strict and onlyundefinedandnullare usable there)forloop to not evaluating them over and over for no need+0.0and0.0are exactly same values[].sliceis shorter thanArray.prototype.slice. Moreover, it convertsargumentsto anarrayfrom the beginning (index0) by default, so you don't need to set it manuallyMath.maxandMath.minwork longer than your own implementationcheckfunction can takeanyvalues now withNumber.isFinite