fix: change to validateIndex_

material-components · Apr 29, 2019 · 03bb86e · 03bb86e
1 parent b828770
commit 03bb86e
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/packages/mdc-menu/foundation.ts b/packages/mdc-menu/foundation.ts
@@ -134,9 +134,7 @@ export class MDCMenuFoundation extends MDCFoundation<MDCMenuAdapter> {
    * @param index Index of list item within the menu.
    */
   setSelectedIndex(index: number) {
-    if (!this.isIndexValid_(index)) {
-      return;
-    }
+    this.validatedIndex_(index);
 
     if (!this.adapter_.isSelectableItemAtIndex(index)) {
       throw new Error('MDCMenuFoundation: No selection group at specified index.');
@@ -152,13 +150,11 @@ export class MDCMenuFoundation extends MDCFoundation<MDCMenuAdapter> {
     this.adapter_.addAttributeToElementAtIndex(index, strings.ARIA_SELECTED_ATTR, 'true');
   }
 
-  private isIndexValid_(index: number): boolean {
+  private validatedIndex_(index: number): void {
     const menuSize = this.adapter_.getMenuItemCount();
     const isIndexInRange = index >= 0 && index < menuSize;
 
-    if (isIndexInRange) {
-      return true;
-    } else {
+    if (!isIndexInRange) {
       throw new Error('MDCMenuFoundation: No list item at specified index.');
     }
   }