From 6f976322cc3811df87eebeff9f035ef0b067b035 Mon Sep 17 00:00:00 2001
From: "Kenneth G. Franqueiro"
Date: Tue, 17 Apr 2018 17:08:49 -0400
Subject: [PATCH] docs(button): Add aria-hidden="true" to icon elements (#2582)
---
demos/button.html | 40 +++++++++----------
docs/theming.md | 2 +-
packages/mdc-button/README.md | 8 ++--
.../mdc-button/classes/baseline.html | 32 +++++++--------
test/screenshot/mdc-button/classes/dense.html | 32 +++++++--------
.../mdc-button/mixins/filled-accessible.html | 8 ++--
.../mixins/horizontal-padding-baseline.html | 16 ++++----
.../mixins/horizontal-padding-dense.html | 16 ++++----
.../mdc-button/mixins/icon-color.html | 16 ++++----
.../mdc-button/mixins/ink-color.html | 16 ++++----
.../mdc-button/mixins/stroke-width.html | 16 ++++----
11 files changed, 101 insertions(+), 101 deletions(-)
diff --git a/demos/button.html b/demos/button.html
index d1c56fa17b9..11f37e49230 100644
--- a/demos/button.html
+++ b/demos/button.html
@@ -119,11 +119,11 @@ Ripple Enabled
Secondary
- favorite
+ favorite
Icon
-
+
@@ -291,11 +291,11 @@ CSS Only
Secondary
- favorite
+ favorite
Icon
-
+
@@ -320,11 +320,11 @@ CSS Only
Secondary
- favorite
+ favorite
Icon
-
+
@@ -350,11 +350,11 @@ CSS Only
Secondary
- favorite
+ favorite
Icon
-
+
@@ -382,11 +382,11 @@ CSS Only
- favorite
+ favorite
Ink Color
- favorite
+ favorite
Icon Color
diff --git a/docs/theming.md b/docs/theming.md
index 004fab6ebca..637c754a35f 100644
--- a/docs/theming.md
+++ b/docs/theming.md
@@ -450,7 +450,7 @@ Then apply the custom class to the button elements:
```html
- favorite
+ favorite
Button
```
diff --git a/packages/mdc-button/README.md b/packages/mdc-button/README.md
index ff56055d4e5..3b40585edd2 100644
--- a/packages/mdc-button/README.md
+++ b/packages/mdc-button/README.md
@@ -55,9 +55,9 @@ semantically correct.
### Adding Icon
Users can nest `mdc-button__icon` inside the button element to add an icon. The icon in button
-is set to 18px to meet legibility requirements.
+is set to 18px to meet legibility requirements. This element should also include `aria-hidden="true"`.
-We recommend you load [Material Icons](https://material.io/icons/) from Google Fonts
+We recommend you load [Material Icons](https://material.io/icons/) from Google Fonts:
```html
@@ -65,7 +65,7 @@ We recommend you load [Material Icons](https://material.io/icons/) from Google F
- favorite
+ favorite
Button
```
@@ -74,7 +74,7 @@ It's also possible to use an SVG icon:
```html
-
+
...
SVG Icon
diff --git a/test/screenshot/mdc-button/classes/baseline.html b/test/screenshot/mdc-button/classes/baseline.html
index 35c38dd1ecb..2faa55819bc 100644
--- a/test/screenshot/mdc-button/classes/baseline.html
+++ b/test/screenshot/mdc-button/classes/baseline.html
@@ -37,13 +37,13 @@
- favorite
+ favorite
Font Icon
-
+
@@ -52,13 +52,13 @@
- favorite
+ favorite
Font Icon
-
+
@@ -78,13 +78,13 @@
- favorite
+ favorite
Font Icon
-
+
@@ -93,13 +93,13 @@
- favorite
+ favorite
Font Icon
-
+
@@ -119,13 +119,13 @@
- favorite
+ favorite
Font Icon
-
+
@@ -134,13 +134,13 @@
- favorite
+ favorite
Font Icon
-
+
@@ -160,13 +160,13 @@
- favorite
+ favorite
Font Icon
-
+
@@ -175,13 +175,13 @@
- favorite
+ favorite
Font Icon
-
+
diff --git a/test/screenshot/mdc-button/classes/dense.html b/test/screenshot/mdc-button/classes/dense.html
index 7a0b4d5646c..b6d719a3413 100644
--- a/test/screenshot/mdc-button/classes/dense.html
+++ b/test/screenshot/mdc-button/classes/dense.html
@@ -37,13 +37,13 @@
- favorite
+ favorite
Font Icon
-
+
@@ -52,13 +52,13 @@
- favorite
+ favorite
Font Icon
-
+
@@ -78,13 +78,13 @@
- favorite
+ favorite
Font Icon
-
+
@@ -93,13 +93,13 @@
- favorite
+ favorite
Font Icon
-
+
@@ -119,13 +119,13 @@
- favorite
+ favorite
Font Icon
-
+
@@ -134,13 +134,13 @@
- favorite
+ favorite
Font Icon
-
+
@@ -160,13 +160,13 @@
- favorite
+ favorite
Font Icon
-
+
@@ -175,13 +175,13 @@
- favorite
+ favorite
Font Icon
-
+
diff --git a/test/screenshot/mdc-button/mixins/filled-accessible.html b/test/screenshot/mdc-button/mixins/filled-accessible.html
index 6e04c89d21d..99002fe2481 100644
--- a/test/screenshot/mdc-button/mixins/filled-accessible.html
+++ b/test/screenshot/mdc-button/mixins/filled-accessible.html
@@ -35,13 +35,13 @@
- favorite
+ favorite
Font Icon
-
+
@@ -50,13 +50,13 @@
- favorite
+ favorite
Font Icon
-
+
diff --git a/test/screenshot/mdc-button/mixins/horizontal-padding-baseline.html b/test/screenshot/mdc-button/mixins/horizontal-padding-baseline.html
index 60617c3034d..148cfe33f89 100644
--- a/test/screenshot/mdc-button/mixins/horizontal-padding-baseline.html
+++ b/test/screenshot/mdc-button/mixins/horizontal-padding-baseline.html
@@ -37,10 +37,10 @@
是
- favorite Icon
+ favorite Icon
- favorite Disabled
+ favorite Disabled
@@ -54,10 +54,10 @@
是
- favorite Icon
+ favorite Icon
- favorite Disabled
+ favorite Disabled
@@ -71,10 +71,10 @@
是
- favorite Icon
+ favorite Icon
- favorite Disabled
+ favorite Disabled
@@ -88,10 +88,10 @@
是
- favorite Icon
+ favorite Icon
- favorite Disabled
+ favorite Disabled
diff --git a/test/screenshot/mdc-button/mixins/horizontal-padding-dense.html b/test/screenshot/mdc-button/mixins/horizontal-padding-dense.html
index 7da90b02db9..979fddd1ff9 100644
--- a/test/screenshot/mdc-button/mixins/horizontal-padding-dense.html
+++ b/test/screenshot/mdc-button/mixins/horizontal-padding-dense.html
@@ -37,10 +37,10 @@
是
- favorite Icon
+ favorite Icon
- favorite Disabled
+ favorite Disabled
@@ -54,10 +54,10 @@
是
- favorite Icon
+ favorite Icon
- favorite Disabled
+ favorite Disabled
@@ -71,10 +71,10 @@
是
- favorite Icon
+ favorite Icon
- favorite Disabled
+ favorite Disabled
@@ -88,10 +88,10 @@
是
- favorite Icon
+ favorite Icon
- favorite Disabled
+ favorite Disabled
diff --git a/test/screenshot/mdc-button/mixins/icon-color.html b/test/screenshot/mdc-button/mixins/icon-color.html
index b6ceafa6801..fdaf6e3ee88 100644
--- a/test/screenshot/mdc-button/mixins/icon-color.html
+++ b/test/screenshot/mdc-button/mixins/icon-color.html
@@ -29,13 +29,13 @@
- favorite
+ favorite
Font Icon
-
+
@@ -44,13 +44,13 @@
- favorite
+ favorite
Font Icon
-
+
@@ -61,13 +61,13 @@
- favorite
+ favorite
Font Icon
-
+
@@ -76,13 +76,13 @@
- favorite
+ favorite
Font Icon
-
+
diff --git a/test/screenshot/mdc-button/mixins/ink-color.html b/test/screenshot/mdc-button/mixins/ink-color.html
index 139e7becde0..6387a0c7063 100644
--- a/test/screenshot/mdc-button/mixins/ink-color.html
+++ b/test/screenshot/mdc-button/mixins/ink-color.html
@@ -35,13 +35,13 @@
- favorite
+ favorite
Font Icon
-
+
@@ -50,13 +50,13 @@
- favorite
+ favorite
Font Icon
-
+
@@ -73,13 +73,13 @@
- favorite
+ favorite
Font Icon
-
+
@@ -88,13 +88,13 @@
- favorite
+ favorite
Font Icon
-
+
diff --git a/test/screenshot/mdc-button/mixins/stroke-width.html b/test/screenshot/mdc-button/mixins/stroke-width.html
index 7579c15cff5..236187e96c8 100644
--- a/test/screenshot/mdc-button/mixins/stroke-width.html
+++ b/test/screenshot/mdc-button/mixins/stroke-width.html
@@ -35,13 +35,13 @@
- favorite
+ favorite
Font Icon
-
+
@@ -50,13 +50,13 @@
- favorite
+ favorite
Font Icon
-
+
@@ -73,13 +73,13 @@
- favorite
+ favorite
Font Icon
-
+
@@ -88,13 +88,13 @@
- favorite
+ favorite
Font Icon
-
+