From 6f976322cc3811df87eebeff9f035ef0b067b035 Mon Sep 17 00:00:00 2001 From: "Kenneth G. Franqueiro" Date: Tue, 17 Apr 2018 17:08:49 -0400 Subject: [PATCH] docs(button): Add aria-hidden="true" to icon elements (#2582) --- demos/button.html | 40 +++++++++---------- docs/theming.md | 2 +- packages/mdc-button/README.md | 8 ++-- .../mdc-button/classes/baseline.html | 32 +++++++-------- test/screenshot/mdc-button/classes/dense.html | 32 +++++++-------- .../mdc-button/mixins/filled-accessible.html | 8 ++-- .../mixins/horizontal-padding-baseline.html | 16 ++++---- .../mixins/horizontal-padding-dense.html | 16 ++++---- .../mdc-button/mixins/icon-color.html | 16 ++++---- .../mdc-button/mixins/ink-color.html | 16 ++++---- .../mdc-button/mixins/stroke-width.html | 16 ++++---- 11 files changed, 101 insertions(+), 101 deletions(-) diff --git a/demos/button.html b/demos/button.html index d1c56fa17b9..11f37e49230 100644 --- a/demos/button.html +++ b/demos/button.html @@ -119,11 +119,11 @@

Ripple Enabled

Secondary @@ -262,11 +262,11 @@

CSS Only

Secondary diff --git a/docs/theming.md b/docs/theming.md index 004fab6ebca..637c754a35f 100644 --- a/docs/theming.md +++ b/docs/theming.md @@ -450,7 +450,7 @@ Then apply the custom class to the button elements: ```html ``` diff --git a/packages/mdc-button/README.md b/packages/mdc-button/README.md index ff56055d4e5..3b40585edd2 100644 --- a/packages/mdc-button/README.md +++ b/packages/mdc-button/README.md @@ -55,9 +55,9 @@ semantically correct. ### Adding Icon Users can nest `mdc-button__icon` inside the button element to add an icon. The icon in button -is set to 18px to meet legibility requirements. +is set to 18px to meet legibility requirements. This element should also include `aria-hidden="true"`. -We recommend you load [Material Icons](https://material.io/icons/) from Google Fonts +We recommend you load [Material Icons](https://material.io/icons/) from Google Fonts: ```html @@ -65,7 +65,7 @@ We recommend you load [Material Icons](https://material.io/icons/) from Google F ``` @@ -74,7 +74,7 @@ It's also possible to use an SVG icon: ```html + - +

@@ -54,10 +54,10 @@ - + - +

@@ -71,10 +71,10 @@ - + - +

@@ -88,10 +88,10 @@ - + - +

diff --git a/test/screenshot/mdc-button/mixins/horizontal-padding-dense.html b/test/screenshot/mdc-button/mixins/horizontal-padding-dense.html index 7da90b02db9..979fddd1ff9 100644 --- a/test/screenshot/mdc-button/mixins/horizontal-padding-dense.html +++ b/test/screenshot/mdc-button/mixins/horizontal-padding-dense.html @@ -37,10 +37,10 @@ - + - +

@@ -54,10 +54,10 @@ - + - +

@@ -71,10 +71,10 @@ - + - +

@@ -88,10 +88,10 @@ - + - +

diff --git a/test/screenshot/mdc-button/mixins/icon-color.html b/test/screenshot/mdc-button/mixins/icon-color.html index b6ceafa6801..fdaf6e3ee88 100644 --- a/test/screenshot/mdc-button/mixins/icon-color.html +++ b/test/screenshot/mdc-button/mixins/icon-color.html @@ -29,13 +29,13 @@