Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ripple circle on mdc-button is oddly-shaped #1184

Closed
acdvorak opened this issue Aug 24, 2017 · 1 comment · Fixed by #1183
Closed

Ripple circle on mdc-button is oddly-shaped #1184

acdvorak opened this issue Aug 24, 2017 · 1 comment · Fixed by #1183

Comments

@acdvorak
Copy link
Contributor

What MDC-Web Version are you using?

0.18.1

What browser(s) is this bug affecting?

All browsers that support ripple. Specifically, I tested in:

  • Chrome 60.0.3112.90
  • Safari 10.1.2
  • Firefox 54.0.1

What OS are you using?

macOS 10.12.6 (Sierra)

What are the steps to reproduce the bug?

  1. Edit demos/button.html to make the button text content wider. E.g.:
    <button class="mdc-button">
      Baseline (very long text)
    </button>
  2. Run the demo server
  3. Go to localhost:8080/button.html
  4. Click on the button whose text you made longer
  5. Observe the ripple width

CodePen

What is the expected behavior?

I'm not sure exactly what the ripple should look like, but it's definitely not correct right now.

What is the actual behavior?

The ::before pseudo-element is super wide:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants