Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MDC List to use mdc-states-color #1560

Closed
lynnmercier opened this issue Nov 7, 2017 · 2 comments
Closed

Update MDC List to use mdc-states-color #1560

lynnmercier opened this issue Nov 7, 2017 · 2 comments
Assignees
Labels

Comments

@lynnmercier
Copy link
Contributor

Use the mdc-states-color mixin created in #1556

MDC List already uses mdc-ripple-color mixin:
https://github.com/material-components/material-components-web/blob/master/packages/mdc-list/mdc-list.scss#L158

this should be replaced with the new mdc-states-color mixin, with any relevant opacity tweaks

@kfranqueiro
Copy link
Contributor

kfranqueiro commented Nov 15, 2017

Note that list presently only applies ripple styles for upgraded ripples with JS component instances. As part of states work, we will want to apply states styles to all list items by default, with an optional modifier class for opting out of this.

However, there is an issue with list / menu / drawer styles: currently, menu and drawer nuke the padding that mdc-list normally applies, which causes problems due to the styles applied for ripples to counteract that padding. (I'm currently under the impression that menu and drawer are applying these styles to properly support separators that extend to both edges of the list, but separators are technically part of mdc-list along with mdc-list-group, so we should probably seek to fix this in mdc-list itself instead.)

Meanwhile, fun fact: Our demo index page uses mdc-list, which means the entire list element will have hover state, but navigation only happens if you actually click the links. We might want to do something about that, but OTOH it might be weird if clicking out in the middle of nowhere navigates.

@kfranqueiro
Copy link
Contributor

Resolved by #1737 + #1738 + #1739.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants