You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is weird, since the ripple/states mixins themselves are responsible for selecting on .mdc-ripple-upgraded. This sort of has the side effect of having no effect on non-upgraded ripples, but it also results in spurious selectors in some places.
We used to do something like this in mdc-list as well, which was resolved in #1737.
Moreover, I'm unsure why we're treating tabs differently between JS and CSS-only. Right now we're actually re-coloring the browser's focus outline for CSS-only tabs rather than using states, which seems like an odd thing to do (and this is the only component we style outline color in).
I'm planning to show this current behavior to our states designer today to confirm whether we should be using states even for the case of CSS-only tabs. If that's indeed the right thing to do, hopefully it means we can simplify tabs' styles and remove some.
The text was updated successfully, but these errors were encountered:
Update: Confirmed with design that CSS-only should also use states shades rather than outline. This means we shouldn't need the .mdc-ripple-upgraded selector within mdc-tab.css, and should be able to remove the outline style.
I noticed yesterday that mdc-tabs is using the ripple/states mixins in an odd way:
material-components-web/packages/mdc-tabs/tab/mdc-tab.scss
Line 161 in fc57923
This is weird, since the ripple/states mixins themselves are responsible for selecting on
.mdc-ripple-upgraded
. This sort of has the side effect of having no effect on non-upgraded ripples, but it also results in spurious selectors in some places.We used to do something like this in mdc-list as well, which was resolved in #1737.
Moreover, I'm unsure why we're treating tabs differently between JS and CSS-only. Right now we're actually re-coloring the browser's focus outline for CSS-only tabs rather than using states, which seems like an odd thing to do (and this is the only component we style outline color in).
I'm planning to show this current behavior to our states designer today to confirm whether we should be using states even for the case of CSS-only tabs. If that's indeed the right thing to do, hopefully it means we can simplify tabs' styles and remove some.
The text was updated successfully, but these errors were encountered: