Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up MDCSelect into sub elements #1982

Closed
lynnmercier opened this issue Jan 17, 2018 · 2 comments
Closed

Split up MDCSelect into sub elements #1982

lynnmercier opened this issue Jan 17, 2018 · 2 comments
Assignees
Labels

Comments

@lynnmercier
Copy link
Contributor

lynnmercier commented Jan 17, 2018

First split MDCSelect into sub elements. This is to help us understand all the logic currently inside MDCSelect.

Follow up PRs will replace the MDCSelect sub elements with public elements, like line ripple, floating label, and notched outline

@lynnmercier
Copy link
Contributor Author

Label and bottom line are split into sub-component.

After taking a look at the adapter for select, I think it is also a good idea to split out a select-menu sub-element.

After that is done we can close this issue

@lynnmercier
Copy link
Contributor Author

Closing this issue because #2399 is going to remove mdc-select's dependency on mdc-menu, which means we should not bother splitting out the menu code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants