Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ripples to components which need it #20

Closed
4 tasks done
traviskaufman opened this issue Dec 5, 2016 · 2 comments
Closed
4 tasks done

Add Ripples to components which need it #20

traviskaufman opened this issue Dec 5, 2016 · 2 comments
Assignees
@traviskaufman @amsheehan
Labels
backlog new-component

Comments

@traviskaufman
Copy link
Contributor

traviskaufman commented Dec 5, 2016 •
edited by amsheehan
Loading

  • Regular buttons
  • FABs
  • Checkboxes
  • Lists (List Items)

Pending #4467

Copied from google/material-design-lite#4614
@traviskaufman traviskaufman added this to the Beta milestone Dec 5, 2016
@sfdexter sfdexter mentioned this issue Dec 16, 2016
Closed
4 tasks
@sgomes sgomes mentioned this issue Dec 29, 2016
Closed
@traviskaufman traviskaufman mentioned this issue Jan 13, 2017
Closed
traviskaufman added a commit that referenced this issue Jan 17, 2017
@traviskaufman
feat(button): Add ink ripple support
623ccb5 
Part of #20
traviskaufman added a commit that referenced this issue Jan 17, 2017
@traviskaufman
feat(fab): Add ink ripple support
d83daa4 
Part of #20
@amsheehan amsheehan self-assigned this Jan 17, 2017
traviskaufman added a commit that referenced this issue Jan 17, 2017
@traviskaufman
feat(button): Add ink ripple support
99f90bf 
Part of #20
traviskaufman added a commit that referenced this issue Jan 17, 2017
@traviskaufman
feat(fab): Add ink ripple support
2204754 
Part of #20
@traviskaufman traviskaufman mentioned this issue Jan 17, 2017
Merged
@traviskaufman traviskaufman self-assigned this Jan 18, 2017
@traviskaufman
Copy link
Contributor Author

@sgomes @amsheehan perhaps we need some follow-up issues regarding incorporating ripples into components which use lists, such as drawers, selects, and menus

traviskaufman added a commit that referenced this issue Jan 18, 2017
@traviskaufman
feat(list): Add interactivity and ink ripple support to mdc-list-item
afeebd8 
- Ensure mdc-list-item looks correct when applied to an anchor tag
- Add ripple support to mdc-list-item
- Ensure that list items with ripples show the ripple across the list
  elemeng
- Tech debt: add gitattributes telling github not to include anything in
  demos/, docs/, or framework-examples/ when computing source code
  language statistics

Part of #20
@traviskaufman traviskaufman mentioned this issue Jan 18, 2017
Merged
@sgomes
Copy link
Contributor

sgomes commented Jan 19, 2017

@traviskaufman Ripples in demos + readme entries pointing to the interactive lists section in the mdc-list readme?

traviskaufman added a commit that referenced this issue Jan 19, 2017
@traviskaufman
feat(button): Add ink ripple support
6fb6e6f 
Part of #20
traviskaufman added a commit that referenced this issue Jan 19, 2017
@traviskaufman
feat(fab): Add ink ripple support
3cc05a3 
Part of #20
traviskaufman added a commit that referenced this issue Jan 19, 2017
@traviskaufman
feat(button): Add ink ripple support
7ef4d9a 
Part of #20
traviskaufman added a commit that referenced this issue Jan 19, 2017
@traviskaufman
feat(fab): Add ink ripple support
7460030 
Part of #20
@traviskaufman traviskaufman reopened this Jan 19, 2017
traviskaufman added a commit that referenced this issue Jan 19, 2017
@traviskaufman
feat(list): Add interactivity and ink ripple support to mdc-list-item
99e148b 
- Ensure mdc-list-item looks correct when applied to an anchor tag
- Add ripple support to mdc-list-item
- Ensure that list items with ripples show the ripple across the list
  elemeng
- Tech debt: add gitattributes telling github not to include anything in
  demos/, docs/, or framework-examples/ when computing source code
  language statistics

Part of #20
traviskaufman added a commit that referenced this issue Jan 19, 2017
@traviskaufman
feat(list): Add interactivity and ink ripple support to mdc-list-item (…
ce0bbf6 
…#191)

- Ensure mdc-list-item looks correct when applied to an anchor tag
- Add ripple support to mdc-list-item
- Ensure that list items with ripples show the ripple across the list
  elemeng
- Tech debt: add gitattributes telling github not to include anything in
  demos/, docs/, or framework-examples/ when computing source code
  language statistics

Part of #20
@amsheehan amsheehan mentioned this issue Jan 24, 2017
Merged
TomTasche added a commit to TomTasche/material-components-web that referenced this issue Mar 29, 2017
@TomTasche
removed link to issue material-components#20
4c81f20 
the issue is closed now and merged to master, so the note should not be necessary anymore
amsheehan pushed a commit that referenced this issue Mar 29, 2017
@TomTasche @amsheehan
docs(getting-started): remove link to issue #20 (#449)
888be2c
pgbross pushed a commit to pgbross/material-components-web that referenced this issue Mar 29, 2017
@TomTasche @pgbross
docs(getting-started): remove link to issue material-components#20 (m…
87ca528 
…aterial-components#449)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@traviskaufman traviskaufman

@amsheehan amsheehan

Labels
backlog new-component
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sgomes @traviskaufman @amsheehan