fix(select): Override floating label properties in select box #2574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2574 +/- ##
=======================================
Coverage 98.66% 98.66%
=======================================
Files 98 98
Lines 4202 4202
Branches 534 534
=======================================
Hits 4146 4146
Misses 56 56Continue to review full report at Codecov.
|
added 2 commits
April 16, 2018 14:19
…mponents/material-components-web into fix/select/label-adjustments
moog16
approved these changes
Apr 16, 2018
kfranqueiro
reviewed
Apr 16, 2018
| .mdc-select__native-control { | ||
| @include mdc-typography(subtitle1); |
There was a problem hiding this comment.
I'm guessing this was removed from label to fix line-height, but do we not want other properties of this style?
There was a problem hiding this comment.
The .mdc-select__label was accidentally left in from the refactor to use mdc-floating-label. mdc-floating-label is already setting the required typography for the label in the mdc-floating-label package.
kfranqueiro
approved these changes
Apr 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with typography and label behavior using the new styles and new floating label.