fix(chips): Rename all entry chips to input chips #2619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moog16
suggested changes
Apr 21, 2018
There was a problem hiding this comment.
rename:
mdc-chips/chip-set/mdc-chip-set.scss
@Keyframes mdc-chip-entry
mdc-chips/chip/constants.js
ENTRY_ANIMATION_NAME
demos/chips.html
Outdated
| var entryButton = document.getElementById('entry-chip-set-button'); | ||
| var inputChipSet = document.getElementById('input-chip-set'); | ||
| var chipSets = document.querySelectorAll('.mdc-chip-set:not(#input-chip-set)'); | ||
| var entryInput = document.getElementById('input-chip-set-input'); |
There was a problem hiding this comment.
I think rename this to just input
|
The keyframe doesn't need to be renamed because it refers to the animation when the chip "enters" the DOM. It just so happens that the animation is only used on input chips. |
Codecov Report
@@ Coverage Diff @@
## master #2619 +/- ##
=======================================
Coverage 98.48% 98.48%
=======================================
Files 98 98
Lines 4230 4230
Branches 537 537
=======================================
Hits 4166 4166
Misses 64 64Continue to review full report at Codecov.
|
moog16
approved these changes
Apr 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Design decision: change name from "entry" to "input" for chips which enable user input by converting text into chips.