Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(infrastructure): Rework goog.module positioning #3098

Merged
merged 1 commit into from
Jul 16, 2018

Conversation

patrickrodee
Copy link
Contributor

@patrickrodee patrickrodee commented Jul 16, 2018

The current goog.module position-finding logic causes problems when there are other comments in the header of the file. This change resolves that.

@codecov-io
Copy link

Codecov Report

Merging #3098 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3098   +/-   ##
=======================================
  Coverage   98.31%   98.31%           
=======================================
  Files         101      101           
  Lines        4451     4451           
  Branches      585      585           
=======================================
  Hits         4376     4376           
  Misses         75       75

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd1f972...213e8ef. Read the comment docs.

Copy link
Contributor

@bwobrien bwobrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrickrodee patrickrodee merged commit fbbf58a into master Jul 16, 2018
@jamesmfriedman jamesmfriedman mentioned this pull request Jul 30, 2018
48 tasks
@allan-chen allan-chen deleted the fix/infrastructure/closure-module-declarations branch January 21, 2020 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants