-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MDCTextField: Rebuild textarea to match spec. #3231
Comments
Thanks so much for bringing this to our attention, James! @kfranqueiro will check with a few folks to see if there's a technical reason it was done this way, or if it was just an oversight/resourcing issue. My gut tells me we should fix this, though. |
I checked with @amsheehan about the history of our textarea styles. We wrote what's currently in MDC Web for textarea prior to the updated text field spec being fully fleshed out - meaning that at the time, we only had underline-only text fields, and that clearly wouldn't fly for a textarea. Now that filled and outlined variants exist, we should update textarea to match. Note that we might want to try to land #2859 before anyone undertakes this, since otherwise there are likely to be a bunch of conflicts between the two. |
at this time: .mdc-text-field--textarea,
.mdc-text-field--focused .mdc-text-field__input:focus {
border-top-color: transparent!important;
border-left-color: transparent!important;
border-right-color: transparent!important;
border-bottom-left-radius: 0;
border-bottom-right-radius: 0;
} with autosize lib: autosize(document.querySelectorAll('textarea')) results: |
Bugs
Follow the template below and include a codepen to ensure the quickest and most accurate response to your issue.
What MDC Web Version are you using?
What browser(s) is this bug affecting?
What OS are you using?
What are the steps to reproduce the bug?
It's a visual bug. I looked through the Material spec and it doesn't specifically talk about Textareas which I'm assuming means they should match non textarea inputs.
What is the expected behavior?
Pending someone telling me the spec says otherwise, they should all match.
What is the actual behavior?
They don't
I'm really looking for opportunities to fix things upstream, this is another one I'd be happy to take on if someone just points me in the right direction.
The text was updated successfully, but these errors were encountered: