Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog open animation broken for v0.38.1 #3345

Closed
trimox opened this issue Aug 14, 2018 · 2 comments
Closed

Dialog open animation broken for v0.38.1 #3345

trimox opened this issue Aug 14, 2018 · 2 comments

Comments

@trimox
Copy link
Contributor

trimox commented Aug 14, 2018

Bugs

What MDC Web Version are you using?

v0.38.1

What browser(s) is this bug affecting?

All

What are the steps to reproduce the bug?

Open a dialog

What is the expected behavior?

dialog-with-animation

What is the actual behavior?

dialog-no-animation

Any other information you believe would be useful?

MDCDialogFoundation.numbers.DIALOG_ANIMATION_TIME_MS is undefined.

this.timerId_ = setTimeout(this.animationTimerEnd_, MDCDialogFoundation.numbers.DIALOG_ANIMATION_TIME_MS);

@kfranqueiro
Copy link
Contributor

Thanks for catching this and sorry for the trouble! Looks like something slipped through on review. I'll send another PR and cut another bugfix release.

@trimox
Copy link
Contributor Author

trimox commented Aug 14, 2018

@kfranqueiro Not a prob! Glad to help, and thank you for the quick PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants