Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDC List: Don't use aria-selected="true" on invalid roles #3403

Closed
abhiomkar opened this issue Aug 23, 2018 · 2 comments
Closed

MDC List: Don't use aria-selected="true" on invalid roles #3403

abhiomkar opened this issue Aug 23, 2018 · 2 comments
Assignees
Milestone

Comments

@abhiomkar
Copy link
Collaborator

As per ARIA spec aria-selected property is used only to specific roles.

@kfranqueiro
Copy link
Contributor

Given that we previously augmented the List component to auto-detect activated behavior vs. selected, we may also be able to auto-detect the presence of roles in which aria-selected is valid, and in other cases opt for aria-current instead (which is the most semantically-correct attribute to use for drawer navigation).

I'm not sure if we'd want to simply build this in to the same check for activated vs. selected... it might work for now, but could still yield invalid combinations down the line.

@kfranqueiro kfranqueiro changed the title MDC List: Remove aria-selected="true" from selected item MDC List: Don't use aria-selected="true" on invalid roles Aug 23, 2018
@kfranqueiro kfranqueiro added this to the R20 milestone Sep 25, 2018
@kfranqueiro
Copy link
Contributor

This was resolved by #4055 insofar as ensuring the correct ARIA roles and attributes are applied within the context of List. We'll open a separate issue around aria-selected vs. aria-current.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants