Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outlined Text Field: shape-radius doesn't factor in Leading Icon #3987

Closed
kfranqueiro opened this issue Oct 24, 2018 · 2 comments · Fixed by #4035
Closed

Outlined Text Field: shape-radius doesn't factor in Leading Icon #3987

kfranqueiro opened this issue Oct 24, 2018 · 2 comments · Fixed by #4035
Assignees
Labels
Milestone

Comments

@kfranqueiro
Copy link
Contributor

kfranqueiro commented Oct 24, 2018

What MDC Web Version are you using?

0.40.x

What browser(s) is this bug affecting?

All

What are the steps to reproduce the bug?

Edit the baseline-leading-icon.html screenshot test page, adding the test-shaped-text-field--outline class to each mdc-text-field--outlined element.

What is the expected behavior?

Floating label should align with the notched outline properly like it does in the shape-radius tests.

What is the actual behavior?

The floating-label style for text field with leading icon is overriding the custom shape radius styles.

Any other information you believe would be useful?

We may be able to factor this into the shape-radius mixin.

The same problem exists in the MDC Select package on the feat/select-new branch (which will be merged for 0.41.0).

@kfranqueiro kfranqueiro added this to the R21 (v0.42.0) milestone Oct 24, 2018
@KNawm
Copy link

KNawm commented Oct 24, 2018

Also in the demo of Textfields not one of the three shaped outlined text fields displays the label correctly

@kfranqueiro
Copy link
Contributor Author

That has already been fixed in #3929 on master, for #3158. This is somewhat of a follow-up though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants