Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snackbar: Create JavaScript API #4062

Closed
7 tasks done
acdvorak opened this issue Nov 7, 2018 · 0 comments
Closed
7 tasks done

Snackbar: Create JavaScript API #4062

acdvorak opened this issue Nov 7, 2018 · 0 comments
Milestone
R21 (v0.42.0)

Comments

@acdvorak
Copy link
Contributor

acdvorak commented Nov 7, 2018 •
edited
Loading

  • Simplify foundation:
    • Remove focus management
    • Remove parameters from show()
  • Create getters/setters for timeout, label text, action text, and esc key behavior
  • Ensure that clients can easily implement queueing
  • Implement [de]registerEventHandler methods in MDCSnackbar instead of adapter (Remove [de]registerEventHandler methods from adapters #2813)
  • Unit tests
@acdvorak acdvorak added this to the R21 (v0.42.0) milestone Nov 7, 2018
@acdvorak acdvorak mentioned this issue Nov 9, 2018
Merged
acdvorak added a commit that referenced this issue Nov 13, 2018
@acdvorak
feat(snackbar): Update styles to match guidelines (#4070)
fa2bc17 
Fixes #4061

This PR also deletes snackbar's JS files and unit tests to avoid spurious test failures.
They will be added back in the next PR (for issue #4062).
acdvorak added a commit that referenced this issue Nov 13, 2018
@acdvorak
feat(snackbar): Update JavaScript API to match guidelines
4dc2138 
Fixes #4062
@acdvorak acdvorak mentioned this issue Nov 13, 2018
Merged
acdvorak added a commit that referenced this issue Nov 16, 2018
@acdvorak
feat(snackbar): Update JavaScript API to match guidelines (#4081)
95c6482 
Fixes #4062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
R21 (v0.42.0)
Development

No branches or pull requests
1 participant
@acdvorak