Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(drawer): add feature targeting for styles #4877

Merged

Conversation

crisbeto
Copy link
Collaborator

@crisbeto crisbeto commented Jul 6, 2019

Adds support for feature targeting to the mdc-drawer styles.

Relates to #4227.

@crisbeto
Copy link
Collaborator Author

crisbeto commented Jul 6, 2019

Here's the output before and after these changes. A few lines got moved around, but it shouldn't make a difference.

before.css.txt
after.css.txt

Copy link
Collaborator

@abhiomkar abhiomkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, minor comments.

packages/mdc-drawer/_mixins.scss Show resolved Hide resolved
Adds support for feature targeting to the `mdc-drawer` styles.

Relates to material-components#4227.
@crisbeto crisbeto force-pushed the drawer-feature-targeting branch from b1f1e5a to 8d2e14c Compare July 10, 2019 16:09
@crisbeto
Copy link
Collaborator Author

Reworked based on the feedback @abhiomkar.

Copy link
Collaborator

@abhiomkar abhiomkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-io
Copy link

codecov-io commented Jul 10, 2019

Codecov Report

Merging #4877 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4877   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files         119      119           
  Lines        5650     5650           
  Branches      749      749           
=======================================
  Hits         5603     5603           
  Misses         46       46           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b7aea1...bccdd92. Read the comment docs.

@abhiomkar abhiomkar merged commit 4d65d29 into material-components:master Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants