-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(drawer): add feature targeting for styles #4877
feat(drawer): add feature targeting for styles #4877
Conversation
Here's the output before and after these changes. A few lines got moved around, but it shouldn't make a difference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, minor comments.
Adds support for feature targeting to the `mdc-drawer` styles. Relates to material-components#4227.
b1f1e5a
to
8d2e14c
Compare
Reworked based on the feedback @abhiomkar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Codecov Report
@@ Coverage Diff @@
## master #4877 +/- ##
=======================================
Coverage 99.16% 99.16%
=======================================
Files 119 119
Lines 5650 5650
Branches 749 749
=======================================
Hits 5603 5603
Misses 46 46
Partials 1 1 Continue to review full report at Codecov.
|
Adds support for feature targeting to the
mdc-drawer
styles.Relates to #4227.