Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDC Simple Menu #783

Closed
touficbatache opened this issue Jun 3, 2017 · 6 comments
Closed

MDC Simple Menu #783

touficbatache opened this issue Jun 3, 2017 · 6 comments

Comments

@touficbatache
Copy link
Contributor

touficbatache commented Jun 3, 2017

Hey,
I was making a template for my web app when I saw that the MDC Simple Menu does not look like the menu from the Material Design guidelines page. On the left we have MDC and on the right we have Material Design guidelines's menu.
mdc2
It's actually different in:

  1. The font-size which should be 16px.
  2. The font-weight which should be 400.
  3. The min-width which should be 170px.
  4. The letter-spacing which should be 0.05px. (Should it be more or less than 0.05px? @robzenn92)

And with all these changes, the menu will look exactly like the one on Material Design guidelines page. On the left we have MDC and on the right we have Material Design guidelines's menu.
mdc

@robzenn92
Copy link
Contributor

robzenn92 commented Jun 4, 2017

@touficbatache From the examples you posted, to me it seems that also the letter-spacing it's a bit different..isn't it? Do you have a PR for that?

@touficbatache
Copy link
Contributor Author

touficbatache commented Jun 4, 2017 via email

@amsheehan
Copy link
Contributor

This looks good. @touficbatache would you mind making a PR for this? What we'd look for are two things:

  • We don't want to change letter spacing. What may be right for one set of typography may not be for another
  • Make sure mdc-typography mixins are used for the solution where appropriate

Thanks!

@touficbatache
Copy link
Contributor Author

@amsheehan Yes sure! What do you mean by "Make sure mdc-typography mixins are used for the solution where appropriate" ?

@amsheehan
Copy link
Contributor

amsheehan commented Jun 5, 2017

Just not to alter properties like font-size and font-weight directly in the component. Use mdc-typography the way it is used on line 137 of mdc-simple-menu.scss

@touficbatache
Copy link
Contributor Author

@amsheehan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants