-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MDC Simple Menu #783
Comments
@touficbatache From the examples you posted, to me it seems that also the letter-spacing it's a bit different..isn't it? Do you have a PR for that? |
Yes it is! I'll fix it later :) I can make a PR but I didn't because I need the approval of MDC Web developers, then I'll create the PR :)
|
This looks good. @touficbatache would you mind making a PR for this? What we'd look for are two things:
Thanks! |
@amsheehan Yes sure! What do you mean by "Make sure mdc-typography mixins are used for the solution where appropriate" ? |
Just not to alter properties like |
Hey,
I was making a template for my web app when I saw that the MDC Simple Menu does not look like the menu from the Material Design guidelines page. On the left we have MDC and on the right we have Material Design guidelines's menu.
It's actually different in:
font-size
which should be16px
.font-weight
which should be400
.min-width
which should be170px
.letter-spacing
which should be0.05px
. (Should it be more or less than 0.05px? @robzenn92)And with all these changes, the menu will look exactly like the one on Material Design guidelines page. On the left we have MDC and on the right we have Material Design guidelines's menu.
The text was updated successfully, but these errors were encountered: