Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Temporary Drawer display error on IE 11 in win10 #881

Closed
ghost opened this issue Jun 30, 2017 · 2 comments · Fixed by #1909
Closed

BUG: Temporary Drawer display error on IE 11 in win10 #881

ghost opened this issue Jun 30, 2017 · 2 comments · Fixed by #1909
Labels
backlog bug

Comments

@ghost
Copy link

ghost commented Jun 30, 2017 •
edited by ghost
Loading

Bugs

What MDC-Web Version are you using?

v0.14.0

What browser(s) is this bug affecting?

IE 11

What OS are you using?

Windows 10

What are the steps to reproduce the bug?

2

What is the expected behavior?

black color background

What is the actual behavior?

grey color background

Any other information you believe would be useful?

the mdl version is ok.
1
@ghost ghost changed the title IE 11 support Temporary Drawer BUG on IE 11 in win10 Jul 3, 2017
@ghost ghost changed the title Temporary Drawer BUG on IE 11 in win10 BUG: Temporary Drawer on IE 11 in win10 Jul 3, 2017
@ghost ghost changed the title BUG: Temporary Drawer on IE 11 in win10 BUG: Temporary Drawer display error on IE 11 in win10 Jul 3, 2017
@amsheehan
Copy link
Contributor

This is indeed a bug! We currently set the background-color of that icon to inherit. Perhaps the correct solution is to set it to transparent for more browser compatibility.

Would you have time to make that change and submit a PR?

@ghost
Copy link
Author

ghost commented Jul 6, 2017

@amsheehan

i put all my energy on a rails project that struggle with code structure and browser compatibility.
in fact, there are more bugs (not submitting) on windows 10 with IE 11.
when free, i will involve it

@acdvorak acdvorak mentioned this issue Jan 9, 2018
Merged
acdvorak added a commit that referenced this issue Jan 10, 2018
@acdvorak
fix(toolbar): Use transparent bg for menu icon to avoid IE 11 bug (#1909
2da3dc8 
)

IE 11 renders the toolbar menu icon with a grey background when the icon's `background-color` is set to `inherit`. Changing the value to `transparent` fixes the bug and doesn't seem to have any adverse affects in other browsers.

Fixes #881

![Screenshot comparison of the bug and the fix](https://user-images.githubusercontent.com/409245/34734739-bd3a7a4c-f521-11e7-8202-c5e6c9b03b0e.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog bug
Projects
None yet
Milestone
No milestone
1 participant
@amsheehan