Change theme's SCSS comment style from /** to //
#1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`//` comments don't appear in the CSS output.
…nts, functions, and mixins
Codecov Report
@@ Coverage Diff @@
## master #1112 +/- ##
=======================================
Coverage 99.93% 99.93%
=======================================
Files 68 68
Lines 3296 3296
Branches 405 405
=======================================
Hits 3294 3294
Misses 2 2Continue to review full report at Codecov.
|
yeelan0319
approved these changes
Aug 11, 2017
packages/mdc-theme/_variables.scss
Outdated
| $mdc-theme-primary: #3f51b5 !default; /* Indigo 500 */ | ||
| $mdc-theme-accent: #ff4081 !default; /* Pink A200 */ | ||
| $mdc-theme-background: #fff !default; /* White */ | ||
| // |
There was a problem hiding this comment.
Super nit: if we introduce no empty lines in other file, could we do consistently in this file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//comments don't appear in the CSS output.