-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(button): Implement stroked button #1194
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline, but for the record: I noticed that in the demo page, the addition of border actually ends up offsetting the text, and as you add to the border-width, it moves the text in the button down, but doesn't move the bottom border, causing the text to become increasingly off-center vertically. Removing the explicit line-height currently set on buttons seems to resolve this, except when applied to <a>
elements which end up with the text aligned to the top. This might be worth more investigation.
packages/mdc-button/mdc-button.scss
Outdated
.mdc-button--stroked { | ||
@include mdc-theme-prop(border-color, text-primary-on-light); | ||
|
||
border-width: 1px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure this is the correct width? Images I've seen so far make it look more like 2px.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed with designer that we set the default border to be 2dp instead of 1dp.
packages/mdc-button/README.md
Outdated
@@ -138,6 +146,7 @@ The provided modifiers are: | |||
| --------------------- | ------------------------------------------------------- | | |||
| `mdc-button--raised` | A contained button that is elevated upon the surface. | | |||
| `mdc-button--unelevated` | A contained button that is flush with the surface. | | |||
| `mdc-button--stroked` | A contained button contained by a rectangular shape. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-wording suggestion: A contained button that is flush with the surface and has a visible border.
Chatted offline. For record keeping: Reason: Solution goes for: Solution considered:
@kfranqueiro Thanks for catching it! |
b711617
to
adadf9c
Compare
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
CLAs look good, thanks! |
929f222
to
2e726e0
Compare
2e726e0
to
a581d0e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1194 +/- ##
======================================
Coverage 99.9% 99.9%
======================================
Files 69 69
Lines 3314 3314
Branches 406 406
======================================
Hits 3311 3311
Misses 3 3 Continue to review full report at Codecov.
|
closes #987